Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont skip host header #1744

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Dont skip host header #1744

merged 3 commits into from
Dec 2, 2020

Conversation

noelzubin
Copy link
Contributor

Closes #1740

@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #1744 (47dd1af) into master (40979fd) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1744      +/-   ##
==========================================
- Coverage   71.40%   71.35%   -0.05%     
==========================================
  Files         178      178              
  Lines       13751    13749       -2     
==========================================
- Hits         9819     9811       -8     
- Misses       3320     3326       +6     
  Partials      612      612              
Flag Coverage Δ
ubuntu 71.33% <100.00%> (-0.02%) ⬇️
windows 69.93% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/http/request.go 80.50% <100.00%> (-0.14%) ⬇️
core/engine.go 90.95% <0.00%> (-2.02%) ⬇️
js/runner.go 80.45% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40979fd...47dd1af. Read the comment docs.

Copy link
Member

@na-- na-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR, @noelzubin. Can you please also add some tests? Specifically:

@na-- na-- requested review from mstoykov and imiric December 1, 2020 10:43
@na-- na-- added this to the v0.30.0 milestone Dec 2, 2020
@na-- na-- merged commit cfedc92 into grafana:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Http response.request.headers are missing "host" value
4 participants