Fix break line after password input (loadimpact#1703) #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
reviewed
Dec 1, 2020
ui/form.go
Outdated
| @@ -65,6 +65,9 @@ func (f Form) Run(r io.Reader, w io.Writer) (map[string]interface{}, error) { | |||
|
|
|||
| color.Set(color.FgCyan) | |||
| s, err := field.GetContents(r) | |||
| if displayLabel == "Password" { | |||
There was a problem hiding this comment.
This would be better off as a type assertion, ensuring that field is of type PasswordField.
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
+ Coverage 71.37% 71.44% +0.07%
==========================================
Files 178 178
Lines 13751 13779 +28
==========================================
+ Hits 9815 9845 +30
+ Misses 3324 3321 -3
- Partials 612 613 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
na--
approved these changes
Dec 4, 2020
salem84
pushed a commit
to salem84/k6
that referenced
this pull request
Feb 3, 2021
* Fix break line after password input (loadimpact#1703) * PasswordField type assertion * Form PasswordField type assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I deleted the branch instead of update the PR and now is duplicated. Anyway thanks for the pointers before.
Closes #1703