Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file schema #2796

Open
chaoran-chen opened this issue Sep 15, 2024 · 1 comment
Open

Config file schema #2796

chaoran-chen opened this issue Sep 15, 2024 · 1 comment
Labels
config Configuration related issues, i.e. helm processing feature Feature proposal v1.0 Tasks that are crucial for a Loculus 1.0 release
Milestone
Priority 1 (highest)

Comments

@chaoran-chen
Copy link
Member

We should fix a format for the Loculus configuration and create a schema.
@chaoran-chen chaoran-chen added config Configuration related issues, i.e. helm processing feature Feature proposal labels Sep 15, 2024
@chaoran-chen chaoran-chen added this to the Release v1.0 milestone Sep 15, 2024
@chaoran-chen chaoran-chen mentioned this issue Sep 15, 2024
Open
@chaoran-chen chaoran-chen added the v1.0 Tasks that are crucial for a Loculus 1.0 release label Oct 1, 2024
@chaoran-chen chaoran-chen modified the milestones: Release v1.0, Priority 1 (highest) Oct 1, 2024
@chaoran-chen chaoran-chen mentioned this issue Oct 1, 2024
Closed
@chaoran-chen chaoran-chen mentioned this issue Oct 9, 2024
Merged
@corneliusroemer
Copy link
Contributor

I don't think we should stabilize the format yet, but an up to date JSON schema would be useful. We can then test the schema against the current values.yaml in CI and find out when changes to the schema are necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
config Configuration related issues, i.e. helm processing feature Feature proposal v1.0 Tasks that are crucial for a Loculus 1.0 release
Projects
Planning
Status: No status
Milestone
Priority 1 (highest)
Development

No branches or pull requests
2 participants
@chaoran-chen @corneliusroemer