feat(ingest/backend): add and use 'x-total-record' header for /get-original-metadata endpoint #2857
+74
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
force-pushed
the
original-x-count
branch
from
cb12656
to
35e63ed
Compare
anna-parker
approved these changes
Sep 23, 2024
| @@ -327,6 +328,10 @@ def get_submitted(config: Config): | |||
| logger.error(f"Error decoding JSON from /get-original-metadata: {response_summary}") | |||
| raise ValueError from err | |||
|
|
|||
| if len(entries) != expected_record_count: | |||
There was a problem hiding this comment.
Only wonder if we should retry here instead of raising an error. The case len(entries) != expected_record_count is most likely to happen at the start of ingest and we then have to wait 30min until the approve rule finishes for the pods to restart.
…/loculus into original-x-count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2847
preview URL: https://original-x-count.loculus.org
Summary
Add and use 'x-total-record' header for /get-original-metadata endpoint in ingest and backend.
Screenshot
PR Checklist