add integration tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mix udp tcp - multiple hosts - snmpv3 connection
- mix udp tcp - multiple hosts - snmpv3 connection
- invalid user - multiple inputs with mix tcp udp hosts
- same security name mix of udp tcp hosts - ipv6 connection
|
Great stuff @kaisecheng! I added a few minor/cosmetic comments. I will be spending more time to run the new testing and followup shortly. |
kaisecheng
force-pushed
the
integration-test
branch
from
6743295 to
2fb2fc8
Compare
…nmp into integration-test � Conflicts: � CHANGELOG.md
|
I believe logstash-plugins/.ci#16 will solve the build problem on 8.0 |
spec/inputs/integration/it_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe "against snmp server", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "against snmp server", :integration => true do | |
| describe "against single snmp server with snmpv2 and udp", :integration => true do |
spec/inputs/integration/it_spec.rb
Outdated
| it_behaves_like "snmp plugin return single event" | ||
| end | ||
|
|
||
| describe "against snmpv3 server", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "against snmpv3 server", :integration => true do | |
| describe "against single server with snmpv3 and tcp", :integration => true do |
| it_behaves_like "snmp plugin return single event" | ||
| end | ||
|
|
||
| describe "invalid user against snmpv3 server", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "invalid user against snmpv3 server", :integration => true do | |
| describe "invalid user against single server with snmpv3 and tcp", :integration => true do |
spec/inputs/integration/it_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe "single plugin input and mix of udp tcp", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "single plugin input and mix of udp tcp", :integration => true do | |
| describe "single input plugin on single server with snmpv2 and mix of udp and tcp", :integration => true do |
spec/inputs/integration/it_spec.rb
Outdated
| plugin.run(queue) | ||
| plugin.close | ||
|
|
||
| host_cnt_snmp1 = queue.reduce(0) { |sum, event| sum + (event.get("host") == "snmp1"? 1: 0) } |
There was a problem hiding this comment.
would something like this be simpler and/or easier to understand?
host_cnt_snmp1 = queue.select {|event| event.get("host") == "snmp1"}.size
spec/inputs/integration/it_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| describe "single plugin input and multiple udp hosts", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "single plugin input and multiple udp hosts", :integration => true do | |
| describe "single input plugin on multiple udp hosts", :integration => true do |
| plugin.run(queue) | ||
| plugin.close | ||
|
|
||
| hosts = queue.map { |event| event.get("host") }.sort |
There was a problem hiding this comment.
or this method here could be used instead of my suggestion with select for the sake of consitency?
spec/inputs/integration/it_spec.rb
Outdated
| it_behaves_like "snmp plugin return one udp event and one tcp event", config | ||
| end | ||
|
|
||
| describe "same security name with different credentials and mix of udp tcp hosts", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "same security name with different credentials and mix of udp tcp hosts", :integration => true do | |
| describe "two plugins on different hosts with snmpv3 with same security name with different credentials and mix of udp and tcp", :integration => true do |
spec/inputs/integration/it_spec.rb
Outdated
| it_behaves_like "snmp plugin return one udp event and one tcp event", config | ||
| end | ||
|
|
||
| describe "ipv6 against snmp1 server", :integration => true do |
There was a problem hiding this comment.
Suggested change
| describe "ipv6 against snmp1 server", :integration => true do | |
| describe "single host with tcp over ipv6 ", :integration => true do |
|
@kaisecheng again, this is great work, overall LGTM, left a few minor comments. Once these are addressed and this is rebased we should be good to merge! |
|
Forgot to add for the record that I successfully tested locally on OSX & Docker and it works great and will be a blessing for future testing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does integration tests against two SNMP dockers with ipv6 to simulate the scenarios below.