Fix: Correctly identify Chinese mobile numbers #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umbers from being classified as Chinese mobile numbers.
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connectors/connector-aliyun-sms/src/index.ts | 📉 -1 Bytes |
gao-sun
reviewed
Apr 28, 2024
| @@ -20,7 +20,7 @@ import { sendSms } from './single-send-text.js'; | |||
| import type { Template } from './types.js'; | |||
| import { aliyunSmsConfigGuard, sendSmsResponseGuard } from './types.js'; | |||
|
|
|||
| const isChinaNumber = (to: string) => /^(\+86|0086|86)?\d{11}$/.test(to); | |||
| const isChinaNumber = (to: string) => /^(\+86|0086|86)\d{11}$/.test(to); | |||
There was a problem hiding this comment.
@logto-io/eng can you guys take a look?
There was a problem hiding this comment.
But the existing data may not have country code prefix, hold this PR until we have a plan for migration.
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Hi @glzjin, after discussion, we think it is better to provider a switch config, to let the user to decide how to treat the numbers without country code. Would you mind adding a config in the "formItems"? |
|
This PR is stale because it has been open 10 for days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Correctly identify Chinese mobile numbers to prevent US mobile numbers from being classified as Chinese mobile numbers.
Testing
Checklist
.changeset