Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why retain scale data? #44

Closed
andreasbrett opened this issue Mar 7, 2021 · 3 comments
Closed

Why retain scale data? #44

andreasbrett opened this issue Mar 7, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@andreasbrett
Copy link
Contributor

Is there a reason for retaining the scale data? I understand why retaining the discovery messages is a must but scale measurements should not need to be retained as Home Assistant should pick them up and then they're not needed anymore.

retain=True,

@andreasbrett andreasbrett added the enhancement New feature or request label Mar 7, 2021
@lolouk44
Copy link
Owner

lolouk44 commented Mar 8, 2021

Hi @andreasbrett

I agree in principle with your comment, however not all users of this repo use HA, that's why I'm publishing with the retain flag.
Did you have any concern with leaving it on?

@andreasbrett
Copy link
Contributor Author

No, no big concerns. I just don't like the idea of my family's personal data dangling on the MQTT server. Maybe I'm just paranoid to be honest... I much prefer the send-and-forget approach. Also I heard the HA devs talking about how retained MQTT messages are a pain (not sure why though). How about making this an option defaulting to retain=True?

@lolouk44
Copy link
Owner

lolouk44 commented Mar 8, 2021

How about making this an option defaulting to retain=True?

That's a good idea. I'll add this on top of your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants