Refactor render package #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felixoid
force-pushed
the
refactor_render_data
branch
2 times, most recently
from
268732e to
092e7cd
Compare
|
Next move - refactoring data parsing, get rid of channels, flattening the query generating. |
Felixoid
force-pushed
the
refactor_render_data
branch
4 times, most recently
from
71ff0f7 to
6e1a4f6
Compare
Felixoid
force-pushed
the
refactor_render_data
branch
6 times, most recently
from
1849091 to
1d7cbc3
Compare
- MultiFetchData: - `FetchDataPoints` is now a method of `MultiFetchRequest` - It returns `[]CHResponse` aka `CHResponses`, not `Reply` - Reorganize it a little bit - MaxDataPoints is checked and reset here - Type `Reply` is renamed to private `query` - `commonStep` is created in `newQuery` - it contains all necessary configs as fields - Data: - Remove rollupObj - Make `EmptyData` a private
- point.Points: Change steps map to reduce memory consumption - where: use int64 timestamps in DateBetween as in other functions = render/data: == data/data.go: - data.Data: rename Aliases to AM as in other types - create data.data to not propagate internals to outside - put logic for async parallel queries processing into data.data - merge parseAggregatedResponse and parseUnaggregatedResponse in parseResponse: aggregated query does not uses nullable anymore, so only one function could be used - split tests for parsers and async functions == data/query.go: - rework aggregated query to get rid of nullables - add conditions type that implies TimeFrame and Targets - decomposite getDataAggregated and getDataUnaggregated methods by implementing logic with contitions methods == data/targets.go: - use TimeFrame instead of until/from values
Felixoid
force-pushed
the
refactor_render_data
branch
from
291e5b5 to
d64b9d4
Compare
Felixoid
force-pushed
the
refactor_render_data
branch
from
c856dbe to
61b8c70
Compare
Civil
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am kindly sorry for such huge changes, but here is only two complex commits, all other things should be easy to review.
So, here are:
-racefor tests