Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locked and Unlocked icons should be reversed #6430

Closed
MohammedAlasaad opened this issue Sep 23, 2020 · 2 comments
Closed

Locked and Unlocked icons should be reversed #6430

MohammedAlasaad opened this issue Sep 23, 2020 · 2 comments
Labels

Comments

@MohammedAlasaad
Copy link

MohammedAlasaad commented Sep 23, 2020

Hi
This is just UI issue. I think the Locked and Unlocked should be reversed.

When you are not authorized its should show locked icon and when you authorized should show unlocked icon.

Screenshot 2020-09-23 at 21 32 14

@raymondfeng
Copy link
Contributor

The icon is from swagger-ui. I think the idea is to click this button to unlock

@MohammedAlasaad
Copy link
Author

MohammedAlasaad commented Sep 23, 2020

As you are not authorized so it should be locked mean not accessible.. yes if u click to unlock.. then first state should be locked :)
is this swagger related issue ?
maybe this one => swagger-api/swagger-ui#4402

I understand the confusion, but it's actually working as expected.
When a user fills the authorization, the lock becomes closed and black - that indicates that there's security information provided. An unlocked lock, means that the user has not provided the information. We've had discussions in the past about how some people expect it to be one way and some the other. We'll consider changing it altogether to make it clearer.

In your case, it behaves as expected (in our intent) - since you allow a no-security option, meaning the user can use the call without providing credentials, the lock is black and locked indicating you can execute the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants