New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upchannels list parser range check error #141

Closed

beitler opened this issue Dec 21, 2021 · 0 comments

Contributor

beitler commented Dec 21, 2021

When specifying the upchannels list, the DRs must be in the range 0-7, however the parser accepts the range 0-(DR_CNT-1), i.e. 0-15:

basicstation/src/s2e.c

Lines 904 to 906 in 60fd978

    
           int minDR = (uj_nextSlot(D), uj_intRange(D, 0, DR_CNT-1)); 
        
           int maxDR = (uj_nextSlot(D), uj_intRange(D, 0, DR_CNT-1)); 
        
           upch_insert(&upchs, insert, freq, BWNIL, minDR, maxDR);

beitler closed this as completed in

ba4f85d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment