[Feature] Add custom notification or one from a list for expiring foods

[let92]

I would like to see the possibility to select from a list of time notifications (e.g. same day, one day before, two days before, 1 week before etc...) or from a custom one for the expiring foods.

I hope it will be implemented in the future.

Thanks in advance for the availability.

[Maan-Sharma]

can i work on this

[lorenzovngl]

can i work on this

Yes of course! Assigned to you

[lorenzovngl]

I would like to see the possibility to select from a list of time notifications (e.g. same day, one day before, two days before, 1 week before etc...) or from a custom one for the expiring foods.

I hope it will be implemented in the future.

Thanks in advance for the availability.

Hello @let92,
I was thinking about your feature request and I want to have a clear understanding of this.
You want to have the possibility to choose how long is the forewarning time. The forewarning time now is fixed (see code below) and you want it to be variable (choosen by the user).

FoodExpirationDates/app/src/main/java/com/lorenzovainigli/foodexpirationdates/model/worker/CheckExpirationsWorker.kt

Lines 37 to 39 in f36191c

	val filteredList = repository.getAll().first().filter {
	it.expirationDate < tomorrow.time.time
	}

Maybe something like:

Notify me when foods expire in

• 1 day
• 2 days
• 1 week
• N days (where N is an input value)

So... if what I described above is what you are asking for, I ask you the question: do you want this option to be global or do you want to choose a custom forewarning time for each food item?

[let92]

I would like to see the possibility to select from a list of time notifications (e.g. same day, one day before, two days before, 1 week before etc...) or from a custom one for the expiring foods.
I hope it will be implemented in the future.
Thanks in advance for the availability.

Hello @let92, I was thinking about your feature request and I want to have a clear understanding of this. You want to have the possibility to choose how long is the forewarning time. The forewarning time now is fixed (see code below) and you want it to be variable (choosen by the user).

FoodExpirationDates/app/src/main/java/com/lorenzovainigli/foodexpirationdates/model/worker/CheckExpirationsWorker.kt

Lines 37 to 39 in f36191c

	val filteredList = repository.getAll().first().filter {
	it.expirationDate < tomorrow.time.time
	}

Maybe something like:

Notify me when foods expire in

• 1 day
• 2 days
• 1 week
• N days (where N is an input value)

So... if what I described above is what you are asking for, I ask you the question: do you want this option to be global or do you want to choose a custom forewarning time for each food item?

Hello @lorenzovngl, what you showed is exactly what I desire.

For my needs, it is fine that the feature is available globally in the app settings.

Thank you very much!

[himanshu-shakya]

Hey! I am new here and I want to contribute. can someone tell me how to start contributing?

[lorenzovngl]

Hey! I am new here and I want to contribute. can someone tell me how to start contributing?

Hello @himanshushakya18, the first step for you is to read the Contribution Guidelines to understand how to contribute.

If you never contributed to a project on GitHub, you can search for issues labeled as good-first-issue, because they are suitable for newcomers. Actually I don't have a good-first-issue on this project, but maybe a can open one and assign to you.

Anyway, if you have any doubt, you can contact me on Twitter/X or LinkedIn (you can find the links on my profile page) and I will guide you step by step.