Introduces on_request and on_complete methods in Faraday::Middleware. #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation on how to leverage the new methods.
|
|
||
| ### Do I need to override `#call`? | ||
|
|
||
| For the majority of middleware, it's not necessary to override the `#call` method, as you can simply use `#on_request` and `#on_response`. |
There was a problem hiding this comment.
This on_response should be on_complete, right?
There was a problem hiding this comment.
Luckily, that was already spot and fixed 🙌
4e9f4b0
There was a problem hiding this comment.
Oh nice! I was just reading through the PRs referenced in the release notes. I didn't think to diff the two versions. 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on_requestandon_completemethods inFaraday::MiddlewareAdditional Notes
Unit tests for
on_completewere a bit complicated to write as they rely on the callback system of theRack::Builder.It would be better to write integration tests for that, but given the limited amount of time I couldn't make it today.