Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmHttp adapter: drop superfluous loaded? check #1213

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

olleolleolle
Copy link
Member

This PR removes a conditional, which is always truthy.

Description

This PR removes a check that I think is superfluous at this point

We are loaded in this section, and loaded meant "has no load errors".

Follow-up of #1202.

Todos

Review.

We are loaded in this section.
@olleolleolle olleolleolle requested a review from iMacTia December 1, 2020 08:26
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree! LGTM

@olleolleolle olleolleolle merged commit 47411d8 into master Dec 1, 2020
@olleolleolle olleolleolle deleted the em-http-loaded-superfluous branch December 1, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants