From 9fe64dd75a22e7aab1b31876477fe6c081755e01 Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 21:53:26 -0700 Subject: [PATCH 1/6] ci: run against ruby 2.7 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ca52a4e30..52bbd5ace 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby: [2.4.x, 2.5.x, 2.6.x] + ruby: [2.4.x, 2.5.x, 2.6.x, 2.7.x] steps: - uses: actions/checkout@v1 From d3939b87963e9d7c1437f5b8d618b5cf62627bfc Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 21:56:14 -0700 Subject: [PATCH 2/6] fix ruby 2.7 warning lib/faraday/adapter/net_http_persistent.rb:13: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call https://github.com/lostisland/faraday/pull/1099/checks?check_run_id=367324080 https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ --- lib/faraday/adapter/net_http_persistent.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/faraday/adapter/net_http_persistent.rb b/lib/faraday/adapter/net_http_persistent.rb index 2465ad93c..ff20c2567 100644 --- a/lib/faraday/adapter/net_http_persistent.rb +++ b/lib/faraday/adapter/net_http_persistent.rb @@ -16,7 +16,7 @@ def net_http_connection(env) if @connection_options.key?(:pool_size) options[:pool_size] = @connection_options[:pool_size] end - Net::HTTP::Persistent.new(options) + Net::HTTP::Persistent.new(**options) else Net::HTTP::Persistent.new('Faraday') end From 90add15ee26c8e4d77a6a092fbd9c7e3833c0909 Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 22:00:38 -0700 Subject: [PATCH 3/6] try exact version --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 52bbd5ace..1dbb0d5ef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby: [2.4.x, 2.5.x, 2.6.x, 2.7.x] + ruby: [2.4.x, 2.5.x, 2.6.x, 2.7.0] steps: - uses: actions/checkout@v1 From f0739438b670bec1f8ef2a43ec094112cf8828d4 Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 22:03:34 -0700 Subject: [PATCH 4/6] or this --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1dbb0d5ef..76e0638b4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby: [2.4.x, 2.5.x, 2.6.x, 2.7.0] + ruby: [2.4.x, 2.5.x, 2.6.x, '2.7'] steps: - uses: actions/checkout@v1 From d347f710b4e45ddb95e03ac5fcdefe091268c4a5 Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 22:13:23 -0700 Subject: [PATCH 5/6] use rvm to install ruby 2.7 --- .github/workflows/ci.yml | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 76e0638b4..de29c8cd5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,7 +38,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - ruby: [2.4.x, 2.5.x, 2.6.x, '2.7'] + ruby: ['2.4', '2.5', '2.6', '2.7'] steps: - uses: actions/checkout@v1 @@ -47,18 +47,25 @@ jobs: run: | sudo apt-get install libcurl4-openssl-dev + - name: Set up RVM + run: | + curl -sSL https://get.rvm.io | bash + - name: Set up Ruby - uses: actions/setup-ruby@v1 - with: - ruby-version: ${{ matrix.ruby }} + run: | + source $HOME/.rvm/scripts/rvm + rvm install ${{ matrix.ruby }} --disable-binary + rvm --default use ${{ matrix.ruby }} - name: Build run: | - gem install bundler + source $HOME/.rvm/scripts/rvm + sudo apt-get install libcurl4-openssl-dev + gem install bundler -v '<2' bundle install --jobs 4 --retry 3 - name: Setup Code Climate - if: matrix.ruby == '2.6.x' + if: matrix.ruby == '2.6' run: | curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter chmod +x ./cc-test-reporter @@ -68,6 +75,6 @@ jobs: run: bundle exec rake - name: Run Code Climate Test Reporter - if: success() && matrix.ruby == '2.6.x' + if: success() && matrix.ruby == '2.6' run: ./cc-test-reporter after-build --coverage-input-type simplecov --exit-code $? continue-on-error: true From 623de960ca4e1d02b289fa626d69239111a1db07 Mon Sep 17 00:00:00 2001 From: technoweenie Date: Sun, 29 Dec 2019 22:20:48 -0700 Subject: [PATCH 6/6] source rvm --- .github/workflows/ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index de29c8cd5..c567eb623 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,7 +72,9 @@ jobs: ./cc-test-reporter before-build - name: Test - run: bundle exec rake + run: | + source $HOME/.rvm/scripts/rvm + bundle exec rake - name: Run Code Climate Test Reporter if: success() && matrix.ruby == '2.6'