Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Timezone: UTC (no DST) #1602

Open
1 task done
JacksonChen666 opened this issue May 1, 2022 · 6 comments
Open
1 task done

Custom Timezone: UTC (no DST) #1602

JacksonChen666 opened this issue May 1, 2022 · 6 comments
Labels
area:settings Related to Settings page and application configration blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) feature-request Request for new features to be added

Comments

@JacksonChen666
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

UI Feature

🔖 Feature description

A timezone that is based off of UTC+00:00 and does not use DST does not exist, and I think it should be added for convenience sake (for those who want to use UTC)

✔️ Solution

Add a custom timezone that is called UTC that is based off of UTC+00:00 and does not have DST.

❓ Alternatives

Using the Africa/Abidjan timezone (should be the equivalent)

📝 Additional Context

I personally prefer over having UTC and then doing my own timezone addition in my head, and do it that way pretty much for other things too (like my website).
I was looking for an option for UTC, but couldn't find one.

@JacksonChen666 JacksonChen666 added the feature-request Request for new features to be added label May 1, 2022
@CommanderStorm
Copy link
Collaborator

There is no advantage to this feature request, right?

I think this should be left as is
image

@JacksonChen666
Copy link
Author

JacksonChen666 commented Jun 10, 2023 via email

@CommanderStorm
Copy link
Collaborator

So basically you want UTC+00 which is here:
image

@CommanderStorm
Copy link
Collaborator

Note that having an extra selection for UTC would be worse, given that we have changed the display of messages to include the timezone marker if an embed is present.
See #3153 for more details

@JacksonChen666
Copy link
Author

So basically you want UTC+00 which is here:

Yes but it's not as clear cut as "choose one and it is UTC". Scoresbysund (now known as Ittoqqortoormiit) is not UTC because it has DST (https://time.is/Ittoqqortoormiit) and UTC does not have DST.

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jun 10, 2023

DST is not supported upstream.
Unless we switch to a different library or dayjs supports this one day, this will not be a feature.

See https://day.js.org/docs/en/manipulate/utc-offset#docsNav
See also iamkun/dayjs#1437

Here is upstream: https://github.com/iamkun/dayjs/blob/dev/src/plugin/timezone/index.js
Here is our clone: https://github.com/louislam/uptime-kuma/tree/master/src/modules/dayjs/plugin/timezone

@CommanderStorm CommanderStorm added area:settings Related to Settings page and application configration question Further information is requested labels Dec 7, 2023
@CommanderStorm CommanderStorm added the blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) label Jan 30, 2024
@CommanderStorm CommanderStorm removed the question Further information is requested label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings Related to Settings page and application configration blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

2 participants