-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans for version 2 #14
Comments
@lovell a million times per day, crazy! |
Would it make sense to add musl detection to the report as well? I started a related PR here: nodejs/node#41338 |
@styfle Yes, the addition of |
The new If anyone would like to help review this, add more containers for integration testing or submit further improvements, all these things are very welcome. https://github.com/lovell/detect-libc/tree/main I plan to publish this as v2.0.0, probably later this week. |
v2.0.0 now available. Please open a new issue if you discover any problems. PRs to add more containers for integration testing are welcome too. |
This module is downloaded about a million times every day (!), and its logic is perhaps run hundreds of times every second.
Making changes to something this highly depended upon is a little frightening, but if we can reduce the time/energy cost then I think it will be worthwhile.
The logic hasn't changed in over four years and (rather amazingly) it all still works, but the ecosystem around it has improved so it's time for this module to do likewise.
Goals:
@mapbox/node-pre-gyp
andprebuild
become first-class concerns (perhaps others? Parcel? Electron?)Progress:
prebuild
will work@mapbox/node-pre-gyp
will workThe text was updated successfully, but these errors were encountered: