Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 delete install via snap, add binary guide, add badges #401

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Aug 15, 2020

snap is not more maintained:
#79
#392

badges preview
image

I changed the license to blue from orange, as I checked some trending repos and blue is a more common choice.

@zwpaper zwpaper requested review from meain and Peltoche as code owners August 15, 2020 16:56
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #401 into master will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   69.65%   69.92%   +0.26%     
==========================================
  Files          19       19              
  Lines        1908     1935      +27     
==========================================
+ Hits         1329     1353      +24     
- Misses        579      582       +3     
Impacted Files Coverage Δ
src/color.rs 79.00% <0.00%> (-0.42%) ⬇️
src/flags.rs 64.00% <0.00%> (-0.17%) ⬇️
src/core.rs 0.00% <0.00%> (ø)
src/meta/mod.rs 18.62% <0.00%> (ø)
tests/integration.rs 100.00% <0.00%> (ø)
src/display.rs 26.66% <0.00%> (+0.27%) ⬆️
src/app.rs 73.91% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0518f...aa3fe29. Read the comment docs.

@meain
Copy link
Member

meain commented Aug 16, 2020

@zwpaper What do you think about having a script that we can host in this repo which the user can just curl and pipe to bash which would pick the latest version and correct architecture and pull down the file and install it?
Not sure how this would work on Windows though.

@zwpaper
Copy link
Member Author

zwpaper commented Aug 16, 2020

@meain happy that we have the same idea.
actually I have done some research for this

In my previous idea, we could just use GitHub assets.
GitHub offered a static link for the latest release, we could omit the version in assets name, and make latest static.

For example

curl -sSL github.com/Peltoche/lsd/releases/latest/download/lsd-$OS-$ARCH.tar.gz | tar zxvf - -C /usr/local/bin/

If we could figure out a solution, I can update this PR and make it happen

@zwpaper
Copy link
Member Author

zwpaper commented Aug 16, 2020

BTW, I nearly not use Windows for dev at all, Windows may be a tough problem for me

@meain
Copy link
Member

meain commented Aug 16, 2020

I am not really sure about the Windows situation either. Don't have access to a Windows machine.

Btw, we probably should be using uname -s and uname -m as that should work pretty well on mac as well.

README.md Outdated Show resolved Hide resolved
@meain
Copy link
Member

meain commented Aug 19, 2020

We could probably drop https://github.com/Peltoche/lsd/blob/master/.snapcraft.yaml since we are not having snap anymore.

@zwpaper
Copy link
Member Author

zwpaper commented Aug 26, 2020

@meain
sorry for the delay, I was overloaded last week...
this PR should be ok to go now

@meain
Copy link
Member

meain commented Aug 26, 2020

No worries, thanks.

@meain meain merged commit 87d1520 into lsd-rs:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants