-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 delete install via snap, add binary guide, add badges #401
Conversation
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 69.65% 69.92% +0.26%
==========================================
Files 19 19
Lines 1908 1935 +27
==========================================
+ Hits 1329 1353 +24
- Misses 579 582 +3
Continue to review full report at Codecov.
|
@zwpaper What do you think about having a script that we can host in this repo which the user can just curl and pipe to bash which would pick the latest version and correct architecture and pull down the file and install it? |
@meain happy that we have the same idea. In my previous idea, we could just use GitHub assets. For example curl -sSL github.com/Peltoche/lsd/releases/latest/download/lsd-$OS-$ARCH.tar.gz | tar zxvf - -C /usr/local/bin/ If we could figure out a solution, I can update this PR and make it happen |
BTW, I nearly not use Windows for dev at all, Windows may be a tough problem for me |
I am not really sure about the Windows situation either. Don't have access to a Windows machine. Btw, we probably should be using |
We could probably drop https://github.com/Peltoche/lsd/blob/master/.snapcraft.yaml since we are not having |
snap is not more maintained: lsd-rs#79 lsd-rs#392
@meain |
No worries, thanks. |
snap is not more maintained:
#79
#392
badges preview
I changed the license to blue from orange, as I checked some trending repos and blue is a more common choice.