Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce type aliases in the logging package #2643

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Jul 2, 2020

This covers all types. It also introduces type aliases for the wire.Frames. STREAM and CRYPTO frames are redefined, so that the logging package doesn't get access to the data sent.

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #2643 into master will increase coverage by 0.05%.
The diff coverage is 90.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2643      +/-   ##
==========================================
+ Coverage   86.32%   86.37%   +0.05%     
==========================================
  Files         122      122              
  Lines        9754     9757       +3     
==========================================
+ Hits         8420     8427       +7     
+ Misses        999      995       -4     
  Partials      335      335              
Impacted Files Coverage Δ
qlog/types.go 84.92% <80.00%> (-2.67%) ⬇️
session.go 76.67% <83.33%> (+0.07%) ⬆️
internal/logutils/frame.go 100.00% <100.00%> (ø)
logging/packet_header.go 100.00% <100.00%> (ø)
qlog/event.go 95.98% <100.00%> (ø)
qlog/frame.go 98.54% <100.00%> (-0.15%) ⬇️
qlog/packet_header.go 94.87% <100.00%> (+0.28%) ⬆️
qlog/qlog.go 93.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673a9f4...ed120f6. Read the comment docs.

@marten-seemann marten-seemann force-pushed the logging-types branch 3 times, most recently from 6ece5ff to e9272f3 Compare July 2, 2020 09:40
@marten-seemann marten-seemann force-pushed the logging-types branch 2 times, most recently from 83282eb to c805cdf Compare July 6, 2020 01:51
@marten-seemann marten-seemann merged commit 05f9428 into master Jul 6, 2020
@marten-seemann marten-seemann deleted the logging-types branch July 6, 2020 02:53
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants