Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce a type for stateless reset tokens #2668

Merged
merged 4 commits into from
Jul 11, 2020

Conversation

marten-seemann
Copy link
Member

Also, pass around the [16]byte by value rather than by pointer. Turns out that's actually faster, and it makes the code a bit cleaner.

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #2668 into master will decrease coverage by 0.16%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2668      +/-   ##
==========================================
- Coverage   86.62%   86.46%   -0.16%     
==========================================
  Files         123      122       -1     
  Lines        9778     9764      -14     
==========================================
- Hits         8470     8442      -28     
- Misses        973      988      +15     
+ Partials      335      334       -1     
Impacted Files Coverage Δ
conn_id_generator.go 90.00% <ø> (-0.32%) ⬇️
internal/protocol/protocol.go 100.00% <ø> (ø)
internal/wire/new_connection_id_frame.go 95.12% <ø> (ø)
server.go 84.57% <ø> (+0.89%) ⬆️
session.go 76.92% <85.71%> (-0.19%) ⬇️
packet_handler_map.go 78.47% <88.89%> (-0.10%) ⬇️
conn_id_manager.go 94.17% <100.00%> (ø)
internal/wire/transport_parameters.go 89.72% <100.00%> (ø)
qlog/event.go 95.98% <100.00%> (ø)
qlog/qlog.go 95.37% <100.00%> (+0.02%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7fa420...a1bb39d. Read the comment docs.

@marten-seemann marten-seemann merged commit 2f5cba0 into master Jul 11, 2020
@marten-seemann marten-seemann deleted the stateless-reset-type branch July 11, 2020 01:49
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants