Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the N connection simulation from the Reno code #2682

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

marten-seemann
Copy link
Member

Removing it from Cubic would be more work, since the hard coded congestion window sizes in the tests would have to be adjusted, and I don't know where to get the expected numbers from.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #2682 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   86.77%   86.77%   -0.01%     
==========================================
  Files         124      124              
  Lines        9875     9869       -6     
==========================================
- Hits         8569     8563       -6     
  Misses        974      974              
  Partials      332      332              
Impacted Files Coverage Δ
internal/congestion/cubic_sender.go 90.65% <100.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2998d...6328acf. Read the comment docs.

@marten-seemann marten-seemann force-pushed the remove-reno-n-connection-simulation branch from 652d624 to dcb8e5b Compare July 22, 2020 15:21
@marten-seemann marten-seemann force-pushed the remove-reno-n-connection-simulation branch from dcb8e5b to 6328acf Compare July 23, 2020 01:43
@marten-seemann marten-seemann merged commit 734aaa6 into master Jul 23, 2020
@marten-seemann marten-seemann deleted the remove-reno-n-connection-simulation branch July 24, 2020 03:58
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants