Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow of the max_ack_delay when parsing transport parameters #2725

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

marten-seemann
Copy link
Member

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #2725 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
- Coverage   86.49%   86.47%   -0.02%     
==========================================
  Files         126      126              
  Lines        9952     9952              
==========================================
- Hits         8607     8605       -2     
- Misses       1013     1014       +1     
- Partials      332      333       +1     
Impacted Files Coverage Δ
internal/protocol/protocol.go 100.00% <ø> (ø)
internal/wire/transport_parameters.go 88.98% <100.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f736d3...d476067. Read the comment docs.

@marten-seemann marten-seemann merged commit 2c43716 into master Aug 20, 2020
@marten-seemann marten-seemann deleted the fix-max-ack-delay-overflow branch August 21, 2020 05:53
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants