Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the os.ErrDeadlineExceeded for stream deadline errors on Go 1.15 #2734

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2552.

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@7c204d4). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2734   +/-   ##
=========================================
  Coverage          ?   86.51%           
=========================================
  Files             ?      128           
  Lines             ?     9956           
  Branches          ?        0           
=========================================
  Hits              ?     8613           
  Misses            ?     1010           
  Partials          ?      333           
Impacted Files Coverage Δ
stream.go 79.07% <ø> (ø)
stream_deadline_error.go 100.00% <100.00%> (ø)
stream_deadline_error_go115.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c204d4...fefdea3. Read the comment docs.

@marten-seemann marten-seemann merged commit eaf5f47 into master Sep 3, 2020
@marten-seemann marten-seemann deleted the err-deadline-exceeded branch September 4, 2020 03:33
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.15: use os.ErrDeadlineExceeded
2 participants