Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that the peer updated its keys when acknowledging a key update #2781

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

marten-seemann
Copy link
Member

The spec says:

An endpoint that receives an acknowledgement that is carried in a packet protected with old keys where any acknowledged packet was protected with newer keys MAY treat that as a connection error of type KEY_UPDATE_ERROR. This indicates that a peer has received and acknowledged a packet that initiates a key update, but has not updated keys in response.

As I claimed in quicwg/base-drafts#4087 (comment), this should be easy to implement.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #2781 into master will increase coverage by 0.02%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2781      +/-   ##
==========================================
+ Coverage   86.90%   86.92%   +0.02%     
==========================================
  Files         133      133              
  Lines       10102    10106       +4     
==========================================
+ Hits         8779     8784       +5     
  Misses        990      990              
+ Partials      333      332       -1     
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 68.14% <0.00%> (ø)
session.go 77.65% <66.67%> (+0.10%) ⬆️
internal/handshake/updatable_aead.go 96.23% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272a2c8...9d4b4f6. Read the comment docs.

@marten-seemann marten-seemann merged commit 06e0db8 into master Sep 17, 2020
@marten-seemann marten-seemann deleted the check-peer-key-update branch September 18, 2020 05:18
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants