correctly handle key updates within the 3 PTO period #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2787 +/- ##
==========================================
+ Coverage 86.02% 86.03% +0.01%
==========================================
Files 133 133
Lines 12071 12077 +6
==========================================
+ Hits 10384 10390 +6
Misses 1355 1355
Partials 332 332
Continue to review full report at Codecov.
|
marten-seemann
force-pushed
the
early-key-drops
branch
from
f1eb4b8
to
7522d09
Compare
lucas-clemente
approved these changes
Sep 22, 2020
We need to: * stop the timer to drop the previous generation * correctly log that the N-1 keys are dropped immediately when keys are updated to N+1
marten-seemann
force-pushed
the
early-key-drops
branch
from
7522d09
to
e94db95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2781.
We need to: