Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail the handshake if the quic_transport_parameter extension is missing #2804

Merged
merged 1 commit into from
Sep 26, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2800.

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #2804 into master will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2804      +/-   ##
==========================================
- Coverage   86.02%   85.99%   -0.02%     
==========================================
  Files         133      133              
  Lines       12063    12067       +4     
==========================================
+ Hits        10376    10377       +1     
- Misses       1355     1356       +1     
- Partials      332      334       +2     
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 65.79% <40.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7999b76...98c437e. Read the comment docs.

@marten-seemann marten-seemann merged commit c92b037 into master Sep 26, 2020
@marten-seemann marten-seemann deleted the check-quic-transport-parameter-extension branch September 26, 2020 10:56
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reject ClientHello / EncryptedExtension without transport parameters
2 participants