Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the first key update immediately after handshake confirmation #2811

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2810.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #2811 into master will increase coverage by 0.02%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2811      +/-   ##
==========================================
+ Coverage   85.92%   85.94%   +0.02%     
==========================================
  Files         133      133              
  Lines       12075    12074       -1     
==========================================
+ Hits        10375    10376       +1     
+ Misses       1365     1363       -2     
  Partials      335      335              
Impacted Files Coverage Δ
internal/handshake/crypto_setup.go 64.88% <0.00%> (-0.26%) ⬇️
internal/handshake/updatable_aead.go 96.13% <85.00%> (-0.06%) ⬇️
session.go 76.97% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe051b...1c38acd. Read the comment docs.

@marten-seemann marten-seemann merged commit 145e7b1 into master Oct 6, 2020
@marten-seemann marten-seemann deleted the fix-first-key-update branch October 6, 2020 13:29
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow key updates as soon as the handshake is confirmed
2 participants