Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow an amplification factor of 3.x #2862

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

marten-seemann
Copy link
Member

This achieves the purpose of the spec: Limit the amplification factor, and simplifies the code by always allowing full-size packets.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2862 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
- Coverage   85.67%   85.67%   -0.01%     
==========================================
  Files         134      134              
  Lines        9087     9083       -4     
==========================================
- Hits         7785     7781       -4     
  Misses        960      960              
  Partials      342      342              
Impacted Files Coverage Δ
internal/ackhandler/sent_packet_handler.go 73.05% <100.00%> (-0.13%) ⬇️
packet_packer.go 83.41% <100.00%> (-0.08%) ⬇️
session.go 77.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272229a...0c2f562. Read the comment docs.

@marten-seemann marten-seemann merged commit 59cafab into master Nov 10, 2020
@marten-seemann marten-seemann deleted the simplify-amplification-limit branch November 11, 2020 09:24
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants