Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary mutex locking in the stream flow controller #2869

Merged
merged 2 commits into from
Nov 21, 2020
Merged

remove unnecessary mutex locking in the stream flow controller #2869

merged 2 commits into from
Nov 21, 2020

Conversation

marten-seemann
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 8, 2020 •
edited
Loading

Codecov Report

Merging #2869 (655632b) into master (69158cf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2869      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.01%     
==========================================
  Files         133      133              
  Lines        9187     9181       -6     
==========================================
- Hits         7880     7874       -6     
  Misses        959      959              
  Partials      348      348
Impacted Files Coverage Δ
internal/flowcontrol/base_flow_controller.go 100.00% <ø> (ø)
internal/flowcontrol/connection_flow_controller.go 100.00% <100.00%> (ø)
internal/flowcontrol/stream_flow_controller.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69158cf...655632b. Read the comment docs.

@marten-seemann marten-seemann force-pushed the remove-unnecessary-mutex-operation branch from faf33e4 to 9acd558 Compare November 9, 2020 01:51
lucas-clemente
lucas-clemente reviewed Nov 10, 2020
View reviewed changes
Copy link
Member

@lucas-clemente lucas-clemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH is showing some unused failures?

internal/flowcontrol/base_flow_controller.go Show resolved Hide resolved
@marten-seemann marten-seemann force-pushed the remove-unnecessary-mutex-operation branch from e5e3064 to 4d6c3d9 Compare November 20, 2020 08:37
@marten-seemann marten-seemann force-pushed the remove-unnecessary-mutex-operation branch from 4d6c3d9 to 655632b Compare November 20, 2020 08:45
@marten-seemann marten-seemann merged commit ed1956f into master Nov 21, 2020
@marten-seemann marten-seemann deleted the remove-unnecessary-mutex-operation branch November 23, 2020 13:56
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-clemente lucas-clemente lucas-clemente left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marten-seemann @lucas-clemente