use PADDING frames to pad packets #2876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2875.
This is a non-trivial rewrite of how we pack packets. Now we compose the payload of an entire datagram (i.e. multiple coalesced packets), before serializing anything. This allows us to add PADDING frames to the Initial packet.
In order for this to work properly, we need to make sure encode the Length field in the Long Header in 2 bytes (even if the actual length would have in 1 byte).