Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the UDP receive buffer size on Windows #2896

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2837.

@marten-seemann marten-seemann changed the title set the UDP receive buffer on Windows set the UDP receive buffer size on Windows Nov 21, 2020
@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #2896 (9d93074) into master (69158cf) will decrease coverage by 0.08%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2896      +/-   ##
==========================================
- Coverage   85.77%   85.70%   -0.08%     
==========================================
  Files         133      133              
  Lines        9187     9194       +7     
==========================================
- Hits         7880     7879       -1     
- Misses        959      963       +4     
- Partials      348      352       +4     
Impacted Files Coverage Δ
internal/flowcontrol/base_flow_controller.go 100.00% <ø> (ø)
conn_windows.go 60.00% <60.00%> (ø)
internal/flowcontrol/connection_flow_controller.go 100.00% <100.00%> (ø)
internal/flowcontrol/stream_flow_controller.go 100.00% <100.00%> (ø)
packet_handler_map.go 72.09% <0.00%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1956f...9d93074. Read the comment docs.

Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, but you should really not use the syscall package directly on linux/darwin and other unixes. Just like you use x/sys/windows for windows, use x/sys/unix for those, which is actively maintained.

The only time it makes sense to use syscall is for std APIs which are stuck with syscall forever, since x/sys/... came after.

@marten-seemann
Copy link
Member Author

Good point. Will do so in a separate PR.

@marten-seemann marten-seemann merged commit 241ceb2 into master Dec 4, 2020
@marten-seemann marten-seemann deleted the read-buffer-windows branch December 4, 2020 02:18
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use golang.org/x/sys/windows for syscalls on Windows
3 participants