Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable key updates when using HTTP/3 to avoid breaking Chrome 87 #2906

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

marten-seemann
Copy link
Member

Fixes #2901.

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #2906 (35690c5) into master (a76879c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   85.77%   85.77%           
=======================================
  Files         133      133           
  Lines        9180     9181    +1     
=======================================
+ Hits         7874     7875    +1     
  Misses        958      958           
  Partials      348      348           
Impacted Files Coverage Δ
http3/server.go 65.16% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76879c...35690c5. Read the comment docs.

Copy link

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Do we want a TODO to remember to remove this at some point later, once Chrome 87 is no longer supported/used anymore?

@marten-seemann
Copy link
Member Author

@mvdan Opened a new issue instead: #2926.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome 87 fails on key updates
3 participants