Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove a redundant error check #3210

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

ebi-yade
Copy link
Contributor

@ebi-yade ebi-yade commented Jun 24, 2021

Hi there,

Thanks for this excellent implementation of QUIC in GO; I'm a beginner at learning it!

This is just a tiny fix, but according to a suggestion by an IDE, the nil checking of the err variable is actually unnecessary here 👀

image

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ebi-yade
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #3210 (f767474) into master (a887f8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3210   +/-   ##
=======================================
  Coverage   85.40%   85.40%           
=======================================
  Files         134      134           
  Lines        9825     9825           
=======================================
  Hits         8391     8391           
  Misses       1060     1060           
  Partials      374      374           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a887f8f...f767474. Read the comment docs.

@marten-seemann marten-seemann changed the title Remove a redundant error checking condition remove a redundant error check Jun 24, 2021
@marten-seemann marten-seemann merged commit e9d12b7 into quic-go:master Jun 24, 2021
@marten-seemann
Copy link
Member

Thank you!

@aschmahmann aschmahmann mentioned this pull request Aug 23, 2021
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants