Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment about congestionWindow value #3310

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

birneee
Copy link
Contributor

@birneee birneee commented Jan 2, 2022

The comment about this field is wrong. I think it should be: "in bytes".

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but you'll need to sign the CLA so we can merge this PR.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #3310 (e9de55b) into master (59958e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3310   +/-   ##
=======================================
  Coverage   85.65%   85.65%           
=======================================
  Files         133      133           
  Lines        9786     9786           
=======================================
  Hits         8382     8382           
  Misses       1029     1029           
  Partials      375      375           
Impacted Files Coverage Δ
internal/congestion/cubic_sender.go 80.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59958e5...e9de55b. Read the comment docs.

@birneee
Copy link
Contributor Author

birneee commented Jan 3, 2022

I have signed it, please rescan

@marten-seemann
Copy link
Member

@birneee
Copy link
Contributor Author

birneee commented Jan 3, 2022

The CLA check failed 14h ago.
I mean it should work now :)

@lucas-clemente
Copy link
Member

Forced a rescan. Sorry about that, not sure why it didn't happen automatically.

@marten-seemann
Copy link
Member

Cool, thank you @lucas-clemente and @birneee!

@marten-seemann marten-seemann merged commit 63b7354 into quic-go:master Jan 3, 2022
@birneee birneee deleted the fix-comment branch December 1, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants