Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a AllowConnectionWindowIncrease config option #3317

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

marten-seemann
Copy link
Member

This option can be used to limit the memory consumption of a QUIC connection. When set, the application can decide if the connection flow control window is increased.

Note that this only applies to the connection flow control window, not to stream windows. However, stream windows are limited by the connection window (the sum of outstanding data on all streams must not exceed the connection window), so this actually does limit the memory usage.

cc @vyzo

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #3317 (45d449a) into master (a98e60c) will decrease coverage by 0.01%.
The diff coverage is 72.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3317      +/-   ##
==========================================
- Coverage   85.65%   85.64%   -0.01%     
==========================================
  Files         133      133              
  Lines        9786     9792       +6     
==========================================
+ Hits         8382     8386       +4     
- Misses       1029     1031       +2     
  Partials      375      375              
Impacted Files Coverage Δ
session.go 77.37% <0.00%> (-0.28%) ⬇️
config.go 100.00% <100.00%> (ø)
internal/flowcontrol/base_flow_controller.go 100.00% <100.00%> (ø)
internal/flowcontrol/connection_flow_controller.go 95.83% <100.00%> (+0.28%) ⬆️
internal/utils/rand.go 75.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a98e60c...45d449a. Read the comment docs.

Copy link

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice and simple

interface.go Outdated Show resolved Hide resolved
interface.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann merged commit 496fbe9 into master Jan 18, 2022
@marten-seemann marten-seemann deleted the allow-window-increase branch January 18, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants