make it possible to parse a varint at the end of a reader #3428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3428 +/- ##
=======================================
Coverage 85.44% 85.44%
=======================================
Files 136 136
Lines 9946 9948 +2
=======================================
+ Hits 8498 8500 +2
Misses 1066 1066
Partials 382 382
Continue to review full report at Codecov.
|
An io.Reader can read into the buffer and return the io.EOF in the same call. In fact, that's how the quic.Stream is implemented. In that case, we shouldn't return an error from quicvarint.Read, otherwise the caller won't be able to parse a varint sent just before a stream was closed.
marten-seemann
force-pushed
the
fix-varint-parsing-eof
branch
from
eca9b31
to
d7622a2
Compare
MarcoPolo
approved these changes
May 26, 2022
| @@ -31,7 +31,10 @@ func NewReader(r io.Reader) Reader { | |||
|
|
|||
| func (r *byteReader) ReadByte() (byte, error) { | |||
| var b [1]byte | |||
| _, err := r.Reader.Read(b[:]) | |||
| n, err := r.Reader.Read(b[:]) | |||
There was a problem hiding this comment.
This is obvious and good as is, but as a general note ReadAtLeast follows the same semantics here (not suggesting we change this here).
nmldiegues
pushed a commit
to chungthuang/quic-go
that referenced
this pull request
Jun 6, 2022
An io.Reader can read into the buffer and return the io.EOF in the same call. In fact, that's how the quic.Stream is implemented. In that case, we shouldn't return an error from quicvarint.Read, otherwise the caller won't be able to parse a varint sent just before a stream was closed.
41 tasks
sudarshan-reddy
pushed a commit
to sudarshan-reddy/quic-go
that referenced
this pull request
Aug 9, 2022
An io.Reader can read into the buffer and return the io.EOF in the same call. In fact, that's how the quic.Stream is implemented. In that case, we shouldn't return an error from quicvarint.Read, otherwise the caller won't be able to parse a varint sent just before a stream was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
io.Readercan read into the buffer and return theio.EOFin the same call. In fact, that's how thequic.Streamis implemented.In that case, we shouldn't return an error from
quicvarint.Read, otherwise the caller won't be able to parse a varint sent just before a stream was closed.