add a logging.NullTracer and logging.NullConnectionTracer #3512
Conversation
Codecov ReportBase: 85.81% // Head: 85.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3512 +/- ##
==========================================
- Coverage 85.81% 85.64% -0.17%
==========================================
Files 134 137 +3
Lines 9851 10497 +646
==========================================
+ Hits 8453 8990 +537
- Misses 1027 1101 +74
- Partials 371 406 +35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
marten-seemann
force-pushed
the
null-connection-tracer
branch
2 times, most recently
from
529e057
to
7389e3e
Compare
marten-seemann
changed the title
The NullConnectionTracer can be embedded, to make it easier to access just a few of the calls.
marten-seemann
force-pushed
the
null-connection-tracer
branch
from
7389e3e
to
48779d0
Compare
logging/null_tracer.go
Outdated
| NullTracer Tracer = &nullTracer{} | ||
| // The NullConnectionTracer is a ConnectionTracer that does nothing. | ||
| // It is useful for embedding. Don't modify this variable! | ||
| NullConnectionTracer ConnectionTracer = &nullConnectionTracer{} |
There was a problem hiding this comment.
Design decision: Should NullConnectionTracer be a variable, or should it be the type?
Advantage variable: There's only a single NullConnectionTracer instance.
Advantage type: makes it really easy to embed, which is not possible when it's a variable.
There was a problem hiding this comment.
Switched it to a type. This makes embedding easier. I don't think having a single instance is actually a problem.
marten-seemann
force-pushed
the
null-connection-tracer
branch
from
ce937b1
to
cd87a64
Compare
|
Merging, since this needs to go into the next release. |
The
NullTracerand theNullConnectionTracercan be embedded, to make it easier to access just a few of the calls.