Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: add request to response #3608

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Conversation

Davincible
Copy link
Contributor

fix: #3605

@google-cla
Copy link

google-cla bot commented Oct 31, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

http3/client_test.go Outdated Show resolved Hide resolved
http3/client.go Outdated Show resolved Hide resolved
http3/client.go Outdated Show resolved Hide resolved
@marten-seemann marten-seemann changed the title fix(http3/client): add request to response http3: add request to response Nov 1, 2022
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 85.48% // Head: 85.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (c4ed40e) compared to base (af30cef).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3608   +/-   ##
=======================================
  Coverage   85.48%   85.48%           
=======================================
  Files         140      140           
  Lines       10271    10272    +1     
=======================================
+ Hits         8780     8781    +1     
  Misses       1106     1106           
  Partials      385      385           
Impacted Files Coverage Δ
http3/client.go 90.50% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@marten-seemann marten-seemann merged commit 047f9b6 into quic-go:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http3: client response does not include request
2 participants