Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/disable departments -> Create a departments API #576

Open
ssempervirens opened this issue Dec 4, 2018 · 3 comments · May be fixed by #660
Open

Remove/disable departments -> Create a departments API #576

ssempervirens opened this issue Dec 4, 2018 · 3 comments · May be fixed by #660
Assignees

Comments

@ssempervirens
Copy link
Member

We should be able to make a department inactive AND remove departments altogether

@McEileen McEileen self-assigned this Mar 15, 2019
@McEileen
Copy link
Collaborator

@sibrahi5 @camfassett I want to be clear on which users have the ability to deactivate apartments, and which users have the ability to remove departments.
I think area coordinators should have the ability to deactivate the department for which they are an AC. I don't think an AC should be able to delete any departments.
I think admins should be able to deactivate and delete any department.
Sound good?

@McEileen
Copy link
Collaborator

NOTE: @sibrahi5 responded to my question in slack and confirmed that the permissions I described are correct.

@McEileen McEileen changed the title Remove/disable departments Remove/disable departments -> Create a departments API Mar 18, 2019
@McEileen
Copy link
Collaborator

(I was originally going to create a new issue and link it, but I thought it would be clearer if I continued the conversation in this issue.)

After poking around the codebase, I decided to create a departments API, similar to the existing users API. I will also create a departments dashboard, which only admins can access, that will be similar to the existing users dashboard. I think this is the clearest and most comprehensive way to implement the ability to remove/disable departments. Other thoughts are welcome!

@McEileen McEileen linked a pull request Apr 25, 2019 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants