Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other auth providers #339

Open
notramo opened this issue May 17, 2024 · 6 comments
Open

Support other auth providers #339

notramo opened this issue May 17, 2024 · 6 comments
Labels
maybe Undecided if this work should be done

Comments

@notramo
Copy link

notramo commented May 17, 2024

Please add email-based and other OAuth providers.

@colebemis
Copy link
Member

Hi, @notramo! What's your use case for this?

@notramo
Copy link
Author

notramo commented May 17, 2024

Some users don't want to give access to all repos to this app.
Others migth want to separate the two accounts.
Some users have GitHub accounts because they use it at work, but they are not allowed to give repo access to 3rd party apps.
Some users prefer libre software platforms, like Codeberg, and don't trust GitHub.
Some might not have GitHub account at all.

Some of the above cases can be worked around by registering a secondary GitHub account, but that's tedious, and in this case it would be simpler to register a Lumen account directly.

Basic e-mail/password, or passkey (Nitrokey, Solokey) auth is universal, and does not require linking any account on other platforms.

@colebemis
Copy link
Member

Some users don't want to give access to all repos to this app.

This makes sense. At some point, I'd love to investigate using a GitHub App instead of a GitHub OAuth app so users can have fine-grained control over which repos Lumen has access to.

Some might not have GitHub account at all.

I might revisit this decision eventually, but for now, GitHub is the only file storage provider Lumen supports. You can't use Lumen if you don't have a GitHub account.

@colebemis colebemis added the maybe Undecided if this work should be done label May 22, 2024
@notramo
Copy link
Author

notramo commented May 22, 2024

I might revisit this decision eventually, but for now, GitHub is the only file storage provider Lumen supports. You can't use Lumen if you don't have a GitHub account.

Is there some technical reasons behind not supporting other storage platforms, or simply “I use this and don't care about others”.

@colebemis
Copy link
Member

Transparently, I built Lumen for personal use with personal preferences. I'm the only maintainer so I prefer to keep the feature set small so it's easier for me to maintain. If you figure out a simple way to implement other storage providers without introducing too much maintenance overhead or design complexity, I'm open to merging it into the project. Also feel free to fork and customize to suit your needs.

@notramo
Copy link
Author

notramo commented May 22, 2024

I will take a look if I can find time for it. Unfortunately, I'm not very familiar with the frameworks used.

By the way, this is a high quality app with good UX. Did you consider adding a cheap paid plan with some extra features?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybe Undecided if this work should be done
Projects
Status: No status
Development

No branches or pull requests

2 participants