Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Footer doesn't stick to bottom #289

Closed
1 task
faboweb opened this issue Dec 29, 2017 · 5 comments · Fixed by #367
Closed
1 task

Footer doesn't stick to bottom #289

faboweb opened this issue Dec 29, 2017 · 5 comments · Fixed by #367
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Dec 29, 2017 •
edited by jbibla
Loading

If there are no denominations, the footer stretches the whole panel.

  • fix ni-page height / footer not being on bottom

image
@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Dec 29, 2017
@jbibla
Copy link
Collaborator

jbibla commented Dec 29, 2017 •
edited
Loading

"Connectivity" is also in the sidebar when on desktop. on Mobile.

@nylira
Copy link
Contributor

nylira commented Jan 12, 2018 •
edited
Loading

Alright guys, I can't recreate either of these issues with yarn testnet on macOS 10.12.

When I set wallet.balances to empty, this is what I see:

screen shot 2018-01-12 at 1 07 18 pm

screen shot 2018-01-12 at 1 09 37 pm

Connectivity isn't in the sidebar for desktop:

screen shot 2018-01-12 at 1 07 24 pm

Connectivity does show up in the sidebar for mobile:

screen shot 2018-01-12 at 1 08 46 pm

screen shot 2018-01-12 at 1 08 41 pm

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 12, 2018

I also tested it and it appears to be fixed. Thx Peng for the very sophisticated test. :)

@faboweb faboweb closed this as completed Jan 12, 2018
@jbibla
Copy link
Collaborator

jbibla commented Jan 12, 2018

i believe this is an issue on the delegation page.

@jbibla jbibla reopened this Jan 12, 2018
@nylira
Copy link
Contributor

nylira commented Jan 15, 2018

@jolesbi can you share a screenshot? Do you mean the .fixed-button-bar is not being fixed to the bottom of the page for mobile?

screen shot 2018-01-15 at 12 57 28 pm

@nylira nylira mentioned this issue Jan 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Peng/289 improve page delegates luniehq/lunie
3 participants
@nylira @faboweb @jbibla