From 8644be820fbef76412afb8ce5bd15b240f8fcb82 Mon Sep 17 00:00:00 2001
From: Billy Rennekamp <billy.rennekamp@gmail.com>
Date: Tue, 29 May 2018 12:34:08 +0200
Subject: [PATCH 1/3] enough test coverage?

---
 CHANGELOG.md                                  |  1 +
 .../components/common/NiModalSearch.vue       |  2 +-
 .../components/govern/PageProposals.vue       | 10 ++++---
 .../components/monitor/PageBlocks.vue         | 15 ++++++-----
 .../components/staking/PageStaking.vue        | 10 ++++---
 .../components/wallet/PageTransactions.vue    | 10 ++++---
 .../renderer/components/wallet/PageWallet.vue | 10 ++++---
 app/src/renderer/vuex/modules/blockchain.js   |  3 +++
 .../components/monitor/PageBlocks.spec.js     | 26 +++++++++++++++----
 .../__snapshots__/PageStaking.spec.js.snap    |  2 +-
 10 files changed, 63 insertions(+), 26 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index af74f70946..7f5d6d9320 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 * The binary is now accepted if it has the same minor version instead of the path version. @faboweb
 * Hid staking button on wallet page @jolesbi
 * Increment version in package.json @jolesbi
+* Made search consistent @okwme
 
 ### Fixes
 
diff --git a/app/src/renderer/components/common/NiModalSearch.vue b/app/src/renderer/components/common/NiModalSearch.vue
index 59485a7ab9..01692b6551 100644
--- a/app/src/renderer/components/common/NiModalSearch.vue
+++ b/app/src/renderer/components/common/NiModalSearch.vue
@@ -11,7 +11,7 @@
           step="1"
           placeholder="View block height..."
           v-model="query")
-        btn(value="Go")
+        btn(value="Find")
         btn(type="button" icon="close" @click.native="close")
       form-msg(name="Query" type="numeric"
         v-if="!$v.filters.blocks.search.query.numeric")
diff --git a/app/src/renderer/components/govern/PageProposals.vue b/app/src/renderer/components/govern/PageProposals.vue
index 75784a4fb8..e16b1b42b9 100644
--- a/app/src/renderer/components/govern/PageProposals.vue
+++ b/app/src/renderer/components/govern/PageProposals.vue
@@ -3,9 +3,9 @@ page(title='Proposals')
   div(slot="menu"): tool-bar
     router-link(to="/proposals/new" exact v-tooltip.bottom="'New Proposal'")
       i.material-icons add
-    a(@click='setSearch(true)' v-tooltip.bottom="'Search'")
+    a(@click='setSearch()' v-tooltip.bottom="'Search'" :disabled="!somethingToSearch")
       i.material-icons search
-  modal-search(type="proposals")
+  modal-search(type="proposals" v-if="somethingToSearch")
 
   data-loading(v-if="proposals.loading")
   data-empty(v-else-if="proposals.length === 0")
@@ -45,6 +45,9 @@ export default {
   },
   computed: {
     ...mapGetters(["proposals", "filters"]),
+    somethingToSearch() {
+      return !this.proposals.loading && !!this.proposals.length
+    },
     filteredProposals() {
       if (this.proposals.items && this.filters) {
         let query = this.filters.proposals.search.query
@@ -113,7 +116,8 @@ export default {
     gotoNewProposal() {
       this.$router.push("/proposals/new")
     },
-    setSearch(bool) {
+    setSearch(bool = !this.filters["proposals"].search.visible) {
+      if (!this.somethingToSearch) return false
       this.$store.commit("setSearchVisible", ["proposals", bool])
     }
   },
diff --git a/app/src/renderer/components/monitor/PageBlocks.vue b/app/src/renderer/components/monitor/PageBlocks.vue
index bbf8361737..300afc03da 100644
--- a/app/src/renderer/components/monitor/PageBlocks.vue
+++ b/app/src/renderer/components/monitor/PageBlocks.vue
@@ -1,10 +1,10 @@
 <template lang="pug">
 page(title='Block Explorer')
   div(slot="menu"): tool-bar
-    a(@click='setSearch(true)' v-tooltip.bottom="'Search Block'")
+    a(@click='setSearch()' v-tooltip.bottom="'Search Block'" :disabled="!somethingToSearch")
       i.material-icons search
 
-  modal-search(type="blocks")
+  modal-search(type="blocks" v-if="somethingToSearch")
 
   data-loading(v-if="blockchain.syncing" title="Node is syncing blockchain…")
   data-loading(v-if="!blockchain.syncing && !blockchain.subscription")
@@ -48,7 +48,10 @@ export default {
     ModalSearch
   },
   computed: {
-    ...mapGetters(["blockchain", "lastHeader"]),
+    ...mapGetters(["blockchain", "lastHeader", "filters"]),
+    somethingToSearch() {
+      return !this.blockchain.syncing && !!this.blocks.length
+    },
     latestBlockTime() {
       return moment(this.lastHeader.time).format("MMMM Do YYYY — hh:mm:ss")
     },
@@ -64,16 +67,14 @@ export default {
     num: num
   }),
   methods: {
-    setSearch(bool) {
+    setSearch(bool = !this.filters["blocks"].search.visible) {
+      if (!this.somethingToSearch) return false
       this.$store.commit("setSearchVisible", ["blocks", bool])
     }
   },
   mounted() {
     Mousetrap.bind(["command+f", "ctrl+f"], () => this.setSearch(true))
     Mousetrap.bind("esc", () => this.setSearch(false))
-  },
-  beforeDestroy() {
-    this.$store.commit("resetSearch", "blocks")
   }
 }
 </script>
diff --git a/app/src/renderer/components/staking/PageStaking.vue b/app/src/renderer/components/staking/PageStaking.vue
index 5b51212cc3..f5e0299f9d 100644
--- a/app/src/renderer/components/staking/PageStaking.vue
+++ b/app/src/renderer/components/staking/PageStaking.vue
@@ -3,10 +3,10 @@ page(title='Staking')
   div(slot="menu"): tool-bar
     a(@click='updateDelegates(address)' v-tooltip.bottom="'Refresh'")
       i.material-icons refresh
-    a(@click='setSearch(true)' v-tooltip.bottom="'Search'")
+    a(@click='setSearch()' v-tooltip.bottom="'Search'" :disabled="!somethingToSearch")
       i.search.material-icons search
 
-  modal-search(type="delegates")
+  modal-search(type="delegates" v-if="somethingToSearch")
 
   .delegates-container
     data-loading(v-if="delegates.loading")
@@ -60,6 +60,9 @@ export default {
     address() {
       return this.user.address
     },
+    somethingToSearch() {
+      return !this.delegates.loading && !!this.delegates.delegates.length
+    },
     filteredDelegates() {
       let query = this.filters.delegates.search.query
 
@@ -141,7 +144,8 @@ export default {
       let candidates = await this.$store.dispatch("getDelegates")
       this.$store.dispatch("getBondedDelegates", candidates)
     },
-    setSearch(bool) {
+    setSearch(bool = !this.filters["delegates"].search.visible) {
+      if (!this.somethingToSearch) return false
       this.$store.commit("setSearchVisible", ["delegates", bool])
     }
   },
diff --git a/app/src/renderer/components/wallet/PageTransactions.vue b/app/src/renderer/components/wallet/PageTransactions.vue
index 45abd90806..15a93814b7 100644
--- a/app/src/renderer/components/wallet/PageTransactions.vue
+++ b/app/src/renderer/components/wallet/PageTransactions.vue
@@ -1,10 +1,10 @@
 <template lang="pug">
 page(title='Transactions')
   div(slot="menu"): tool-bar
-    a(@click='setSearch(true)' v-tooltip.bottom="'Search'")
+    a(@click='setSearch()' v-tooltip.bottom="'Search'" :disabled="!somethingToSearch")
       i.material-icons search
 
-  modal-search(type="transactions")
+  modal-search(type="transactions" v-if="somethingToSearch")
 
   data-loading(v-if="wallet.historyLoading")
   data-empty-tx(v-else-if='transactions.length === 0')
@@ -45,6 +45,9 @@ export default {
   },
   computed: {
     ...mapGetters(["filters", "transactions", "wallet", "config"]),
+    somethingToSearch() {
+      return !this.wallet.historyLoading && !!this.transactions.length
+    },
     orderedTransactions() {
       let list = orderBy(
         this.transactions,
@@ -73,7 +76,8 @@ export default {
     }
   }),
   methods: {
-    setSearch(bool) {
+    setSearch(bool = !this.filters["transactions"].search.visible) {
+      if (!this.somethingToSearch) return false
       this.$store.commit("setSearchVisible", ["transactions", bool])
     }
   },
diff --git a/app/src/renderer/components/wallet/PageWallet.vue b/app/src/renderer/components/wallet/PageWallet.vue
index 03b09cc514..dfd5b97f5e 100644
--- a/app/src/renderer/components/wallet/PageWallet.vue
+++ b/app/src/renderer/components/wallet/PageWallet.vue
@@ -3,10 +3,10 @@ page(title='Wallet')
   div(slot="menu"): tool-bar
     a(@click='updateBalances()' v-tooltip.bottom="'Refresh'")
       i.material-icons refresh
-    a(@click='setSearch(true)' v-tooltip.bottom="'Search'")
+    a(@click='setSearch()' v-tooltip.bottom="'Search'" :disabled="!somethingToSearch")
       i.material-icons search
 
-  modal-search(type="balances")
+  modal-search(type="balances" v-if="somethingToSearch")
 
   part(title='Your Address')
     list-item(
@@ -66,6 +66,9 @@ export default {
   },
   computed: {
     ...mapGetters(["filters", "wallet", "committedDelegations", "config"]),
+    somethingToSearch() {
+      return !this.wallet.balancesLoading && !!this.wallet.balances.length
+    },
     allDenomBalances() {
       // for denoms not in balances, add empty balance
       let balances = this.wallet.balances.slice(0)
@@ -99,7 +102,8 @@ export default {
     }
   },
   methods: {
-    setSearch(bool) {
+    setSearch(bool = !this.filters["balances"].search.visible) {
+      if (!this.somethingToSearch) return false
       this.$store.commit("setSearchVisible", ["balances", bool])
     },
     updateBalances() {
diff --git a/app/src/renderer/vuex/modules/blockchain.js b/app/src/renderer/vuex/modules/blockchain.js
index 9b6015285d..7a775cbfb2 100644
--- a/app/src/renderer/vuex/modules/blockchain.js
+++ b/app/src/renderer/vuex/modules/blockchain.js
@@ -11,6 +11,9 @@ export default ({ commit, node }) => {
   }
 
   const mutations = {
+    setBlocks(state, blocks) {
+      state.blocks = blocks
+    },
     setBlock(state, block) {
       state.block = block
     },
diff --git a/test/unit/specs/components/monitor/PageBlocks.spec.js b/test/unit/specs/components/monitor/PageBlocks.spec.js
index 8715b8540d..5d1e749c7d 100644
--- a/test/unit/specs/components/monitor/PageBlocks.spec.js
+++ b/test/unit/specs/components/monitor/PageBlocks.spec.js
@@ -50,13 +50,29 @@ describe("PageBlocks", () => {
     expect(htmlBeautify(wrapper.html())).toMatchSnapshot()
   })
 
-  it("should call resetSearch on beforeDestroy", () => {
-    wrapper.destroy()
-    expect(store.commit).toHaveBeenCalledWith("resetSearch", "blocks")
-  })
+  // it("should update 'somethingToSearch' when there's nothing to search", () => {
+  //   expect(wrapper.vm.somethingToSearch).toBe(true)
+  //   wrapper.setData({
+  //     getters: {
+  //       blockchain: () => ({
+  //         blocks: []
+  //       })
+  //     }
+  //   })
+  //   console.log(wrapper.vm.blocks)
+  //   // store.commit("setBlocks", [])
+  //   wrapper.update()
+  //   console.log(wrapper.vm.blocks)
+  //   expect(wrapper.vm.somethingToSearch).toBe(false)
+  // })
+  //
+  // it("should not call resetSearch on beforeDestroy", () => {
+  //   wrapper.destroy()
+  //   expect(store.commit).toHaveBeenCalledWith("resetSearch", "blocks")
+  // })
 
   it("should show the search on click", () => {
-    wrapper.vm.setSearch(true)
+    wrapper.vm.setSearch()
     expect(store.commit).toHaveBeenCalledWith("setSearchVisible", [
       "blocks",
       true
diff --git a/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap b/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap
index c1fe32db3e..b4d089ba1a 100644
--- a/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap
+++ b/test/unit/specs/components/staking/__snapshots__/PageStaking.spec.js.snap
@@ -20,7 +20,7 @@ exports[`PageStaking has the expected html structure 1`] = `
             <div class=\\"ni-tool-bar\\">
                <div class=\\"ni-tool-bar-container\\">
                   <div class=\\"main\\">
-                     <a><i class=\\"material-icons\\">refresh</i></a><a><i class=\\"search material-icons\\">search</i></a>
+                     <a><i class=\\"material-icons\\">refresh</i></a><a disabled=\\"disabled\\"><i class=\\"search material-icons\\">search</i></a>
                   </div>
       <a class=\\"back\\"><i class=\\"material-icons\\">arrow_back</i></a><a class=\\"help\\"><i class=\\"material-icons\\">help_outline</i></a><a class=\\"sign-out\\"><i class=\\"material-icons\\">exit_to_app</i></a>
    </div>

From 6821f873a15c0398529c34022e3d6fc6887df663 Mon Sep 17 00:00:00 2001
From: Billy Rennekamp <billy.rennekamp@gmail.com>
Date: Tue, 29 May 2018 15:47:18 +0200
Subject: [PATCH 2/3] test coverage

---
 app/src/renderer/vuex/modules/delegates.js    |  21 ++-
 app/src/renderer/vuex/modules/wallet.js       |   7 +-
 .../components/common/NiModalSearch.spec.js   |  18 ++-
 .../components/monitor/PageBlocks.spec.js     |  41 +++---
 .../components/staking/PageStaking.spec.js    |  39 ++++--
 .../wallet/PageTransactions.spec.js           | 128 ++++++++++--------
 .../components/wallet/PageWallet.spec.js      |   6 +
 test/unit/specs/store/blockchain.spec.js      |   7 +-
 test/unit/specs/store/filters.spec.js         |   6 +
 9 files changed, 175 insertions(+), 98 deletions(-)

diff --git a/app/src/renderer/vuex/modules/delegates.js b/app/src/renderer/vuex/modules/delegates.js
index e2bb76c4ca..b5f5ea892e 100644
--- a/app/src/renderer/vuex/modules/delegates.js
+++ b/app/src/renderer/vuex/modules/delegates.js
@@ -7,6 +7,12 @@ export default ({ dispatch, node }) => {
   }
 
   const mutations = {
+    setDelegateLoading(state, loading) {
+      state.loading = loading
+    },
+    setDelegates(state, delegates) {
+      state.delegates = delegates
+    },
     addDelegate(state, delegate) {
       delegate.id = delegate.pub_key.data
       Object.assign(delegate, delegate.description)
@@ -24,24 +30,25 @@ export default ({ dispatch, node }) => {
   }
 
   const actions = {
-    reconnected({ state, dispatch }) {
+    reconnected({ state, commit, dispatch }) {
       if (state.loading) {
         dispatch("getDelegates")
       }
     },
-    async getDelegates({ state, dispatch, rootState }) {
-      state.loading = true
+    async getDelegates({ state, dispatch, rootState, commit }) {
+      commit("setDelegateLoading", true)
       let delegatePubkeys = (await node.candidates()).data
       await Promise.all(
         delegatePubkeys.map(pubkey => {
           return dispatch("getDelegate", pubkey)
         })
       )
-      state.delegates = indicateValidators(
-        state.delegates,
-        rootState.config.maxValidators
+      commit(
+        "setDelegates",
+        indicateValidators(state.delegates, rootState.config.maxValidators)
       )
-      state.loading = false
+      commit("setDelegateLoading", false)
+
       return state.delegates
     },
     async getDelegate({ commit }, pubkey) {
diff --git a/app/src/renderer/vuex/modules/wallet.js b/app/src/renderer/vuex/modules/wallet.js
index cda44bfa5a..74bed1bf68 100644
--- a/app/src/renderer/vuex/modules/wallet.js
+++ b/app/src/renderer/vuex/modules/wallet.js
@@ -15,6 +15,9 @@ export default ({ commit, node }) => {
   }
 
   let mutations = {
+    setHistoryLoading(state, loading) {
+      state.historyLoading = loading
+    },
     setWalletBalances(state, balances) {
       state.balances = balances
       state.balancesLoading = false
@@ -80,7 +83,7 @@ export default ({ commit, node }) => {
       dispatch("queryWalletBalances")
     },
     async queryWalletHistory({ state, commit, dispatch }) {
-      state.historyLoading = true
+      commit("setHistoryLoading", true)
       // let res = await node.coinTxs(state.address)
       // XXX
       let res = []
@@ -96,7 +99,7 @@ export default ({ commit, node }) => {
       await Promise.all(
         blockHeights.map(h => dispatch("queryTransactionTime", h))
       )
-      state.historyLoading = false
+      commit("setHistoryLoading", false)
     },
     async queryTransactionTime({ commit, dispatch }, blockHeight) {
       let blockMetaInfo = await dispatch("queryBlockInfo", blockHeight)
diff --git a/test/unit/specs/components/common/NiModalSearch.spec.js b/test/unit/specs/components/common/NiModalSearch.spec.js
index 55f4dcdf11..15f1ca9f0c 100644
--- a/test/unit/specs/components/common/NiModalSearch.spec.js
+++ b/test/unit/specs/components/common/NiModalSearch.spec.js
@@ -1,12 +1,14 @@
 import NiModalSearch from "common/NiModalSearch"
 import setup from "../../../helpers/vuex-setup"
+import Vuelidate from "vuelidate"
 
 describe("NiModalSearch", () => {
   let wrapper, store
-  let { mount } = setup()
+  let { mount, shallow, localVue } = setup()
 
   beforeEach(() => {
     let instance = mount(NiModalSearch, { propsData: { type: "transactions" } })
+    localVue.use(Vuelidate)
     store = instance.store
     wrapper = instance.wrapper
     store.commit("setSearchVisible", ["transactions", true])
@@ -39,4 +41,18 @@ describe("NiModalSearch", () => {
       "def"
     ])
   })
+
+  it("should show find button on blocks", () => {
+    wrapper.setProps({ type: "blocks" })
+    store.commit("setSearchVisible", ["blocks", true])
+    store.commit("setSearchVisible", ["transactions", false])
+    wrapper.update()
+
+    expect(
+      wrapper
+        .find(".ni-modal-search-field .ni-btn__value")
+        .text()
+        .trim()
+    ).toBe("Find")
+  })
 })
diff --git a/test/unit/specs/components/monitor/PageBlocks.spec.js b/test/unit/specs/components/monitor/PageBlocks.spec.js
index 5d1e749c7d..4577b0a30e 100644
--- a/test/unit/specs/components/monitor/PageBlocks.spec.js
+++ b/test/unit/specs/components/monitor/PageBlocks.spec.js
@@ -4,7 +4,7 @@ import PageBlocks from "renderer/components/monitor/PageBlocks"
 
 describe("PageBlocks", () => {
   let wrapper, store
-  let { mount } = setup()
+  let { mount, shallow } = setup()
 
   let block = {
     header: {
@@ -50,21 +50,30 @@ describe("PageBlocks", () => {
     expect(htmlBeautify(wrapper.html())).toMatchSnapshot()
   })
 
-  // it("should update 'somethingToSearch' when there's nothing to search", () => {
-  //   expect(wrapper.vm.somethingToSearch).toBe(true)
-  //   wrapper.setData({
-  //     getters: {
-  //       blockchain: () => ({
-  //         blocks: []
-  //       })
-  //     }
-  //   })
-  //   console.log(wrapper.vm.blocks)
-  //   // store.commit("setBlocks", [])
-  //   wrapper.update()
-  //   console.log(wrapper.vm.blocks)
-  //   expect(wrapper.vm.somethingToSearch).toBe(false)
-  // })
+  it("should update 'somethingToSearch' when there's nothing to search", () => {
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    let instance = shallow(PageBlocks, {
+      stubs: { "modal-search": "<modal-search />" },
+      getters: {
+        lastHeader: () => ({
+          time: 1608,
+          last_block_id: { hash: "123" },
+          height: 12345
+        }),
+        blockchain: () => ({
+          blocks: [],
+          block,
+          blockMetaInfo: { block_id: { hash: "hash" } },
+          blockHeight: null,
+          blockLoading: false,
+          subscription: true,
+          blockMetas: []
+        })
+      }
+    })
+    wrapper = instance.wrapper
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+  })
   //
   // it("should not call resetSearch on beforeDestroy", () => {
   //   wrapper.destroy()
diff --git a/test/unit/specs/components/staking/PageStaking.spec.js b/test/unit/specs/components/staking/PageStaking.spec.js
index 61ba07d39a..823ed5e4cc 100644
--- a/test/unit/specs/components/staking/PageStaking.spec.js
+++ b/test/unit/specs/components/staking/PageStaking.spec.js
@@ -5,15 +5,8 @@ import PageStaking from "renderer/components/staking/PageStaking"
 describe("PageStaking", () => {
   let wrapper, store
   let { mount } = setup()
-
-  beforeEach(() => {
-    let instance = mount(PageStaking)
-    wrapper = instance.wrapper
-    store = instance.store
-
-    store.state.user.address = "abc"
-    store.commit("setAtoms", 1337)
-    store.commit("addDelegate", {
+  let delegates = [
+    {
       pub_key: {
         type: "ed25519",
         data: "pubkeyX"
@@ -25,8 +18,8 @@ describe("PageStaking", () => {
         moniker: "candidateX",
         country: "USA"
       }
-    })
-    store.commit("addDelegate", {
+    },
+    {
       pub_key: {
         type: "ed25519",
         data: "pubkeyY"
@@ -38,7 +31,17 @@ describe("PageStaking", () => {
         moniker: "candidateY",
         country: "Canada"
       }
-    })
+    }
+  ]
+  beforeEach(() => {
+    let instance = mount(PageStaking)
+    wrapper = instance.wrapper
+    store = instance.store
+
+    store.state.user.address = "abc"
+    store.commit("setAtoms", 1337)
+    store.commit("addDelegate", delegates[0])
+    store.commit("addDelegate", delegates[1])
     wrapper.update()
   })
 
@@ -101,6 +104,18 @@ describe("PageStaking", () => {
     ).toContain("2")
   })
 
+  it("should update 'somethingToSearch' when there's nothing to search", () => {
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    store.commit("setDelegates", [])
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+
+    store.commit("addDelegate", delegates[0])
+    store.commit("addDelegate", delegates[1])
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    store.commit("setDelegateLoading", true)
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+  })
+
   it("should show placeholder if delegates are loading", () => {
     let { wrapper } = mount(PageStaking, {
       getters: {
diff --git a/test/unit/specs/components/wallet/PageTransactions.spec.js b/test/unit/specs/components/wallet/PageTransactions.spec.js
index 7220d80974..75d2e3ccea 100644
--- a/test/unit/specs/components/wallet/PageTransactions.spec.js
+++ b/test/unit/specs/components/wallet/PageTransactions.spec.js
@@ -4,7 +4,64 @@ import PageTransactions from "renderer/components/wallet/PageTransactions"
 describe("PageTransactions", () => {
   let wrapper, store
   let { mount } = setup()
-
+  let transactions = [
+    {
+      tx: {
+        hash: "x",
+        inputs: [
+          {
+            coins: [
+              {
+                denom: "jbcoins",
+                amount: 1234
+              }
+            ],
+            sender: "myAddress"
+          }
+        ],
+        outputs: [
+          {
+            coins: [
+              {
+                denom: "jbcoins",
+                amount: 1234
+              }
+            ],
+            recipient: "otherAddress"
+          }
+        ]
+      },
+      time: Date.now()
+    },
+    {
+      tx: {
+        hash: "y",
+        inputs: [
+          {
+            coins: [
+              {
+                denom: "fabocoins",
+                amount: 1234
+              }
+            ],
+            sender: "otherAddress"
+          }
+        ],
+        outputs: [
+          {
+            coins: [
+              {
+                denom: "fabocoins",
+                amount: 1234
+              }
+            ],
+            recipient: "myAddress"
+          }
+        ]
+      },
+      time: Date.now() + 10
+    }
+  ]
   beforeEach(() => {
     let instance = mount(PageTransactions, {
       stubs: {
@@ -16,64 +73,7 @@ describe("PageTransactions", () => {
     store = instance.store
 
     store.commit("setWalletAddress", "myAddress")
-    store.commit("setWalletHistory", [
-      {
-        tx: {
-          hash: "x",
-          inputs: [
-            {
-              coins: [
-                {
-                  denom: "jbcoins",
-                  amount: 1234
-                }
-              ],
-              sender: "myAddress"
-            }
-          ],
-          outputs: [
-            {
-              coins: [
-                {
-                  denom: "jbcoins",
-                  amount: 1234
-                }
-              ],
-              recipient: "otherAddress"
-            }
-          ]
-        },
-        time: Date.now()
-      },
-      {
-        tx: {
-          hash: "y",
-          inputs: [
-            {
-              coins: [
-                {
-                  denom: "fabocoins",
-                  amount: 1234
-                }
-              ],
-              sender: "otherAddress"
-            }
-          ],
-          outputs: [
-            {
-              coins: [
-                {
-                  denom: "fabocoins",
-                  amount: 1234
-                }
-              ],
-              recipient: "myAddress"
-            }
-          ]
-        },
-        time: Date.now() + 10
-      }
-    ])
+    store.commit("setWalletHistory", transactions)
 
     wrapper.update()
   })
@@ -109,6 +109,16 @@ describe("PageTransactions", () => {
     expect(wrapper.vm.filteredTransactions.map(x => x.tx.hash)).toEqual(["x"])
   })
 
+  it("should update 'somethingToSearch' when there's nothing to search", () => {
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    store.commit("setWalletHistory", [])
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+    store.commit("setWalletHistory", transactions)
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    store.commit("setHistoryLoading", true)
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+  })
+
   it("should show an error if there are no transactions", () => {
     store.commit("setWalletHistory", [])
     wrapper.update()
diff --git a/test/unit/specs/components/wallet/PageWallet.spec.js b/test/unit/specs/components/wallet/PageWallet.spec.js
index 14e1cf176f..e86d2a4f2a 100644
--- a/test/unit/specs/components/wallet/PageWallet.spec.js
+++ b/test/unit/specs/components/wallet/PageWallet.spec.js
@@ -109,6 +109,12 @@ describe("PageWallet", () => {
     ).toBe("123")
   })
 
+  it("should update 'somethingToSearch' when there's nothing to search", () => {
+    expect(wrapper.vm.somethingToSearch).toBe(true)
+    store.commit("setWalletBalances", [])
+    expect(wrapper.vm.somethingToSearch).toBe(false)
+  })
+
   it("has a number of staked tokens", () => {
     expect(wrapper.vm.stakedTokens).toBe(123)
   })
diff --git a/test/unit/specs/store/blockchain.spec.js b/test/unit/specs/store/blockchain.spec.js
index dd9d3a1b2f..ea46e14e8d 100644
--- a/test/unit/specs/store/blockchain.spec.js
+++ b/test/unit/specs/store/blockchain.spec.js
@@ -20,10 +20,15 @@ describe("Module: Blockchain", () => {
     store.state.blockchain.blockMetas = [blockMeta]
   })
 
-  it("sets blocks", () => {
+  it("sets block", () => {
     store.commit("setBlock", { test: "test" })
     expect(store.state.blockchain.block).toEqual({ test: "test" })
   })
+  it("sets blocks", () => {
+    let payload = [{ foo: "bar" }, { hello: "world" }]
+    store.commit("setBlocks", payload)
+    expect(store.state.blockchain.blocks).toEqual(payload)
+  })
 
   it("sets block meta info", () => {
     store.commit("setBlockMetaInfo", { test: "test" })
diff --git a/test/unit/specs/store/filters.spec.js b/test/unit/specs/store/filters.spec.js
index b2925fad04..8f734e2d07 100644
--- a/test/unit/specs/store/filters.spec.js
+++ b/test/unit/specs/store/filters.spec.js
@@ -18,6 +18,12 @@ describe("Module: Filters", () => {
 
     store.commit("setSearchVisible", ["balances", false])
     expect(state.balances.search.visible).toBe(false)
+
+    store.commit("setSearchVisible", ["balances", true])
+    expect(state.balances.search.visible).toBe(true)
+
+    store.commit("resetSearch", "balances")
+    expect(state.balances.search.visible).toBe(false)
   })
 
   it("can set a search type's query", () => {

From 1ff25d18e2e23848fb5ea4b14112e8a24ca3b125 Mon Sep 17 00:00:00 2001
From: Jordan Bibla <jbibla@gmail.com>
Date: Tue, 29 May 2018 16:01:03 -0400
Subject: [PATCH 3/3] bumping up that code cov

---
 .../components/monitor/PageBlocks.spec.js     | 24 +++++++++++++++----
 .../components/staking/PageStaking.spec.js    | 15 ++++++++++++
 .../wallet/PageTransactions.spec.js           | 13 ++++++++++
 .../components/wallet/PageWallet.spec.js      |  6 +++++
 4 files changed, 53 insertions(+), 5 deletions(-)

diff --git a/test/unit/specs/components/monitor/PageBlocks.spec.js b/test/unit/specs/components/monitor/PageBlocks.spec.js
index 4577b0a30e..aaef4497d5 100644
--- a/test/unit/specs/components/monitor/PageBlocks.spec.js
+++ b/test/unit/specs/components/monitor/PageBlocks.spec.js
@@ -74,11 +74,6 @@ describe("PageBlocks", () => {
     wrapper = instance.wrapper
     expect(wrapper.vm.somethingToSearch).toBe(false)
   })
-  //
-  // it("should not call resetSearch on beforeDestroy", () => {
-  //   wrapper.destroy()
-  //   expect(store.commit).toHaveBeenCalledWith("resetSearch", "blocks")
-  // })
 
   it("should show the search on click", () => {
     wrapper.vm.setSearch()
@@ -87,4 +82,23 @@ describe("PageBlocks", () => {
       true
     ])
   })
+
+  it("should not show search when there is nothing to search", () => {
+    let instance = shallow(PageBlocks, {
+      stubs: { "modal-search": "<modal-search />" },
+      getters: {
+        lastHeader: () => ({
+          last_block_id: { hash: "123" }
+        }),
+        blockchain: () => ({
+          blocks: []
+        })
+      }
+    })
+    wrapper = instance.wrapper
+    wrapper.update()
+
+    expect(store.commit).not.toHaveBeenCalled()
+    expect(wrapper.vm.setSearch()).toEqual(false)
+  })
 })
diff --git a/test/unit/specs/components/staking/PageStaking.spec.js b/test/unit/specs/components/staking/PageStaking.spec.js
index 823ed5e4cc..020b91c839 100644
--- a/test/unit/specs/components/staking/PageStaking.spec.js
+++ b/test/unit/specs/components/staking/PageStaking.spec.js
@@ -129,4 +129,19 @@ describe("PageStaking", () => {
 
     expect(wrapper.contains("data-loading")).toBe(true)
   })
+
+  it("should not show search when there is nothing to search", () => {
+    let { wrapper } = mount(PageStaking, {
+      getters: {
+        delegates: () => ({
+          delegates: [],
+          loading: true
+        })
+      },
+      stubs: { "data-loading": "<data-loading />" }
+    })
+    wrapper.update()
+
+    expect(wrapper.vm.setSearch()).toEqual(false)
+  })
 })
diff --git a/test/unit/specs/components/wallet/PageTransactions.spec.js b/test/unit/specs/components/wallet/PageTransactions.spec.js
index 75d2e3ccea..eaacee15e2 100644
--- a/test/unit/specs/components/wallet/PageTransactions.spec.js
+++ b/test/unit/specs/components/wallet/PageTransactions.spec.js
@@ -124,4 +124,17 @@ describe("PageTransactions", () => {
     wrapper.update()
     expect(wrapper.contains("data-empty-tx")).toBe(true)
   })
+
+  it("should not show search when there is nothing to search", () => {
+    let transactions = []
+    let instance = mount(PageTransactions, {
+      stubs: {
+        "li-transaction": "<li-transaction />",
+        "data-empty-tx": "<data-empty-tx />"
+      }
+    })
+    store.commit("setWalletHistory", transactions)
+    wrapper.update()
+    expect(wrapper.vm.setSearch()).toEqual(false)
+  })
 })
diff --git a/test/unit/specs/components/wallet/PageWallet.spec.js b/test/unit/specs/components/wallet/PageWallet.spec.js
index e86d2a4f2a..8a57e87a7e 100644
--- a/test/unit/specs/components/wallet/PageWallet.spec.js
+++ b/test/unit/specs/components/wallet/PageWallet.spec.js
@@ -115,6 +115,12 @@ describe("PageWallet", () => {
     expect(wrapper.vm.somethingToSearch).toBe(false)
   })
 
+  it("should not show search when there's nothing to search", () => {
+    store.commit("setWalletBalances", [])
+    wrapper.update()
+    expect(wrapper.vm.setSearch()).toEqual(false)
+  })
+
   it("has a number of staked tokens", () => {
     expect(wrapper.vm.stakedTokens).toBe(123)
   })