removed double checking lock

matteobaccan · Sep 2, 2019 · 0b2d209 · 0b2d209
1 parent 11ca019
commit 0b2d209
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/owner/src/main/java/org/aeonbits/owner/loaders/XMLLoader.java b/owner/src/main/java/org/aeonbits/owner/loaders/XMLLoader.java
@@ -38,15 +38,11 @@ public class XMLLoader implements Loader {
     private static final long serialVersionUID = -894351666332018767L;
     private transient SAXParserFactory factory = null;
 
-    private SAXParserFactory factory() {
+    private synchronized SAXParserFactory factory() {
         if (factory == null) {
-            synchronized (this) {
-                if (factory == null) {
-                    factory = SAXParserFactory.newInstance();
-                    factory.setValidating(true);
-                    factory.setNamespaceAware(true);
-                }
-            }
+            factory = SAXParserFactory.newInstance();
+            factory.setValidating(true);
+            factory.setNamespaceAware(true);
         }
         return factory;
     }