Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 encoding properties. Resolves #77 #78

Merged
merged 1 commit into from
May 23, 2014

Conversation

SvetaNesterenko
Copy link
Contributor

I would like to contribute to your project and I decided to get started with this issue. I am not sure if I did this right, so I would appreciate any comments.

@lviggiano
Copy link
Collaborator

I think that the implementation is correct. But, a unit test, to prove that
utf-8 encoded properties file are loaded properly is needed. You can add
it, or I will, before merging.
Il 22/mag/2014 21:44 "SvetaNesterenko" notifications@github.com ha
scritto:

I would like to contribute to your project and I decided to get started
with this issue. I am not sure if I did this right, so I would appreciate

any comments.

You can merge this Pull Request by running

git pull https://github.com/SvetaNesterenko/owner utf8-fix

Or view, comment on, or merge it at:

#78
Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com//pull/78
.

lviggiano pushed a commit that referenced this pull request May 23, 2014
 UTF-8 encoding properties. Resolves #77
@lviggiano lviggiano merged commit 463875d into matteobaccan:master May 23, 2014
@lviggiano
Copy link
Collaborator

Merged, thanks. If you could provide a unit test, then, we can consider #77 closed.

@SvetaNesterenko
Copy link
Contributor Author

Thanks, I'll write the test.

@lviggiano
Copy link
Collaborator

I'll release asap with your fix. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants