Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shortcut editor #1325

Open
tsujan opened this issue Mar 2, 2021 · 6 comments
Open

Add a shortcut editor #1325

tsujan opened this issue Mar 2, 2021 · 6 comments
Assignees

Comments

@tsujan
Copy link
Member

tsujan commented Mar 2, 2021

Self-explanatory but not straightforward because several shortcuts are defined inside the code and should be excluded from the future shortcut editor (I've encountered and handled the same situation elsewhere).

@antis81
Copy link

antis81 commented Sep 13, 2021

Do you think we should turn globalkeysd -> Core into a shared library? Since the "grabber" works stable we don't need to think about the rest for now. Also the library could provide the "countdown" button from lxqt-globalkeys.

Strings should be friendly to QKeySequence. The only Qt signal provided is Core::shortcutGrabbed(). Adding QString parameter to the signal probably is a good idea (because threaded). However one can read back the grabbed string.

Should be sane don't you think?

@tsujan
Copy link
Member Author

tsujan commented Sep 14, 2021

No extra shared library is needed for such jobs.

@antis81
Copy link

antis81 commented Sep 14, 2021

In no way did I mention the term "extra". Personally I see an API more suitable than message bus for this task. How do you plan to record a shortcut?

@tsujan
Copy link
Member Author

tsujan commented Sep 14, 2021

How do you plan to record a shortcut?

No need to a plan; Qt does it. See lximage-qt's code, for example.

@antis81
Copy link

antis81 commented Sep 14, 2021

Okay 👍

@ralf3u
Copy link

ralf3u commented Mar 17, 2024

The shortcut editor could be inside the Preferences, with the title Shortcuts.
If there will be a shortcut editor, then it would be good to add the following entry:

Mark first item

With that entry I could set the shortcut Home for Mark first item. So, by doing this, I could not only mark the first item with the space-key but also with the Home-key, so the issue #1169 could be solved that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants