incorrect pinyin: 卡 > qiǎ instead of 卡 > kǎ

[glowinthedark]

import pinyin

pinyin.get('这里不收信用卡。', delimiter=" ")
# Out[3]: 'zhè lǐ bù shōu xìn yòng qiǎ 。'

Expected output:

 'zhè lǐ bù shōu xìn yòng kǎ 。'

[casserlyprogramming]

That is because https://github.com/lxyu/pinyin/blob/master/pinyin/pinyin.py#L19-L20 only takes the first option and

pinyin/pinyin/Mandarin.dat

Line 6391 in f9cac59

5361 QIA3 KA3

has two. In all cases with multiple options what is the correct way to handle that? Should we return all possible sentences or are there rules in mandarin to dictate which pronunciation is correct? (My Mandarin is hsk3 at best so I don't know the answer to the last question).

[ri-aje]

That is because https://github.com/lxyu/pinyin/blob/master/pinyin/pinyin.py#L19-L20 only takes the first option and

pinyin/pinyin/Mandarin.dat

Line 6391 in f9cac59

5361 QIA3 KA3

has two. In all cases with multiple options what is the correct way to handle that? Should we return all possible sentences or are there rules in mandarin to dictate which pronunciation is correct? (My Mandarin is hsk3 at best so I don't know the answer to the last question).

then essentially all the multi-sound chars are reduced to the first sound listed, which is not even necessarily the most popular sound, e.g., 5361 is more often pronounced as KA3 than it is QIA3. unless the code can do some smart semantics analysis to figure out the correct sound given the context, I would say let pinyin.get to return a list or generator, enumerating all possible pronunciations, at least this gives the caller a chance to decide which one to go. bonus it should also work for cases where there isn't enough context to determine what would be the correct sound, e.g., pinyin.get('卡') should return all possible sounds as there is no context to determine which sound wins out here.