Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore links in prefix attributes #1209

Closed
mre opened this issue Aug 11, 2023 · 3 comments · Fixed by #1536
Closed

Ignore links in prefix attributes #1209

mre opened this issue Aug 11, 2023 · 3 comments · Fixed by #1536
Labels
good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed

Comments

@mre
Copy link
Member

mre commented Aug 11, 2023

E.g.

<html lang="en-EN" prefix="og: https://ogp.me/ns#">
@mre mre added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 27, 2023
@xlai89
Copy link
Contributor

xlai89 commented May 5, 2024

Hi @mre ,

I had a very good first experience with lychee. Thank you for developing the tool!
I am also learning to program more with rust and to contribute more in the OS community.
May I try working on this issue?

Some guidance would be really helpful though.
Is it a valid way to extend the element/attribute combinations in html5gum.rs and html5ever.rs and then add "html" into the function is_verbatim_elem? Would this impact other use cases, where "html" should not be excluded, when include_verbatim is false?

@mre
Copy link
Member Author

mre commented May 13, 2024

Hey @xlai89,
thanks for considering to work on this! That would be great. 👍

The changes would be quite similar to #1187.
Perhaps you want to tackle that one first? You can try to follow the comments and see if you can help out.
It's of course totally fine to also tackle this issue first. You'll probably follow the same structure anyway, so the order shouldn't matter that much.

@xlai89
Copy link
Contributor

xlai89 commented May 16, 2024

Thanks for the hint. I'll try to understand and maybe work on PR #1187 first.

@xlai89 xlai89 mentioned this issue Oct 19, 2024
Merged
@mre mre closed this as completed in #1536 Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest-accepted help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore links in prefix attributes xlai89/lychee
2 participants
@mre @xlai89