Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist name used as credits may be inserted into artist table instead of actual artist name #1010

Closed
lydavid opened this issue Jul 14, 2024 · 3 comments

Comments

@lydavid
Copy link
Owner

lydavid commented Jul 14, 2024

If the user first navigates to an artist's page through the subtitle of a release page where their name is credited as something else, that name will be inserted into the database for them.

This is most noticeable for artists whose name may be in different languages on different releases. Depending on which one the user navigates from, the artist name will be inserted with a different name.
We should always prefer to use the artist name as it appears in MusicBrainz.
This issue is most likely because we pass the name during navigation.
The reason I did this was so that the title did not show blank while loading. I can keep doing this, but upon loading lookup, insert that instead of the passed in name

@lydavid
Copy link
Owner Author

lydavid commented Jul 16, 2024

can't repro

@lydavid lydavid closed this as completed Jul 16, 2024
@lydavid
Copy link
Owner Author

lydavid commented Aug 3, 2024

Screenshot_20240802-110527
Screenshot_20240802-110647

@lydavid lydavid reopened this Aug 3, 2024
@lydavid
Copy link
Owner Author

lydavid commented Aug 3, 2024

I got this when navigating from graph view to the artist for the first time

@lydavid lydavid closed this as completed in debf0ab Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant