Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppprt scenes based apps #55

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Conversation

kirillyakimovich
Copy link
Member

For scenes based apps (iOS 13 and higher) window scene is not set automatically, so this check make every test fail:

if #available(iOS 13.0, *) {
    guard self.window.windowScene?.activationState == .foregroundActive else {
        return false
    }
}

This PR sets windowScene if it's not set.

@marcosgriselli marcosgriselli changed the base branch from main to xcode-15-4 June 12, 2024 01:33
@marcosgriselli marcosgriselli force-pushed the suppprt-scene-based-apps branch from 028255e to 215e8e4 Compare June 12, 2024 01:33
@marcosgriselli
Copy link
Contributor

Updated the base here so that CI can run

@gabriellanata gabriellanata merged commit 52ef933 into xcode-15-4 Jun 12, 2024
5 checks passed
@gabriellanata gabriellanata deleted the suppprt-scene-based-apps branch June 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants