feat: improve user experience for nested NodeExecutions #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: show workflow node name beneath node execution ids * feat: updating DetailsPanel info for NodeExecutions * fix lint errors * adding tests for new formatter function * test: adding new test for NodeExecutionDetails * test: adding test for new code in NodeExecutionsTable
* refactor: fetch child node executions to determine expandability * fix: handling detection of children for sub-workflows as well * fix: poor performance with object-hash on some identifiers * docs: cleanup and docs for newly exposed functions * test: ensure request config is used for all levels * chore: remove unused import
* refactor: removing specialized rows and rendering only nodes * refactor: moving contexts up to common folder * refactor: use a data cache for nested node mapping * refactor: update loading of workflow data * fix: update usage of NodeExecutions in graph tab * fix: update TaskExecutionDetails to use data cache * fix: getting tests and stories working again * chore: docs and cleanup * test: use a more robust element query * refactor: use filter instead of reduce * docs: adding some missing function docs
* test: creating dynamic task cases for NodeExecutionsTable stories * fix: styling for child group labels * fix: mock api context for NodeExecutionsTable stories * test: mock nodeExecutionData endpoint * chore: remove unused imports * fix: extract nodes from subworkflows as well * fix: adjust borders to make child groups more obvious * refactor: checkpoint for getting the nesting styles correct * refactor: adding logic for borders/spacing based on nesting/index * fix: correct workflow execution table row styles
schottra
force-pushed
the
dynamic-task-updates
branch
from
5caf9b6
to
097d94b
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 59.22% 62.67% +3.44%
==========================================
Files 365 361 -4
Lines 5687 5647 -40
Branches 847 837 -10
==========================================
+ Hits 3368 3539 +171
+ Misses 2319 2108 -211
Continue to review full report at Codecov.
|
wild-endeavor
approved these changes
Jun 30, 2020
|
rubber stamp... i don't know what a javascript is. |
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jun 30, 2020
# [0.7.0](http://github.com/lyft/flyteconsole/compare/v0.6.0...v0.7.0) (2020-06-30) ### Features * improve user experience for nested NodeExecutions ([#77](http://github.com/lyft/flyteconsole/issues/77)) ([58ed1a4](http://github.com/lyft/flyteconsole/commit/58ed1a4176afeb0c13c34cf0cced13efa91ea7b4)), closes [#70](http://github.com/lyft/flyteconsole/issues/70) [#72](http://github.com/lyft/flyteconsole/issues/72) [#75](http://github.com/lyft/flyteconsole/issues/75) [#76](http://github.com/lyft/flyteconsole/issues/76)
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch makes some improvements to the UX for nested NodeExecutions
All changes on this branch have been reviewed as part of previous PRs: #70, #72, #75, #76