Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18nManager.setDefaultLocale(Locale locale) lacks some functionality #14

Open
GoogleCodeExporter opened this issue Oct 8, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

I18nManager.setDefaultLocale(Locale newLocale) changes the locale for all
the I18n objects created via I18nFactory but I think it should also call
Locale.setDefault(newLocale) so that all new I18n objects would also come
with the newLocale.

Evaldas Juska

Original issue reported on code.google.com by evk...@gmail.com on 13 Sep 2007 at 3:26

@GoogleCodeExporter
Copy link
Author

In the previous version I18nManager.setDefaultLocale() also set the global 
default. I
found that that is an unexpected and potentially undesired side-effect so I 
took it
out in the current release. 
It's a valid point though that the name of the method suggests that all locale
objects created after will have that locale set. We may need to reconsider and
potentially add another API call.

Original comment by steffen....@googlemail.com on 13 Sep 2007 at 4:19

  • Added labels: AffectsVersion-0.9.1

@GoogleCodeExporter
Copy link
Author

We can also document the current behavior better for that method and advise 
callers to also call 
Locale.setDefault().

If there are no objections, I will do this when I get a chance.

Original comment by berge...@gmail.com on 20 Mar 2010 at 11:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant